https://bugzilla.redhat.com/show_bug.cgi?id=1066613 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gtkdialog See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Texinfo files are installed using install-info in %post and %preun if package has .info files. Note: Texinfo .info file(s) in gtkdialog-doc See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING-elementary-icons in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 5 files have unknown license. Detailed output of licensecheck in /home/rpmaker/Desktop/gtkdialog/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/gtkdialog [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/gtkdialog, /usr/share/gtkdialog [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, fedora-logos, eom), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, fedora-logos, eom), /usr/share/icons/hicolor(hicolor-icon-theme, fedora-logos) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 696320 bytes in 44 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. Note: Incorrect Requires : /usr/local/bin/gtkdialog See: http://fedoraproject.org/wiki/Packaging/Guidelines#FileDeps [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gtkdialog- doc , gtkdialog-examples [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 1.1.36 starting... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Mock Version: 1.1.36 INFO: Mock Version: 1.1.36 Start: lock buildroot INFO: installing package(s): /home/rpmaker/Desktop/gtkdialog/results/gtkdialog-0.8.3-1.fc21.i686.rpm /home/rpmaker/Desktop/gtkdialog/results/gtkdialog-doc-0.8.3-1.fc21.noarch.rpm /home/rpmaker/Desktop/gtkdialog/results/gtkdialog-examples-0.8.3-1.fc21.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/', '--releasever', '21', 'install', '/home/rpmaker/Desktop/gtkdialog/results/gtkdialog-0.8.3-1.fc21.i686.rpm', '/home/rpmaker/Desktop/gtkdialog/results/gtkdialog-doc-0.8.3-1.fc21.noarch.rpm', '/home/rpmaker/Desktop/gtkdialog/results/gtkdialog-examples-0.8.3-1.fc21.noarch.rpm', '--setopt=tsflags=nocontexts'] Error: Package: gtkdialog-examples-0.8.3-1.fc21.noarch (/gtkdialog-examples-0.8.3-1.fc21.noarch) Requires: /usr/local/bin/gtkdialog You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest Rpmlint ------- Checking: gtkdialog-0.8.3-1.fc21.i686.rpm gtkdialog-doc-0.8.3-1.fc21.noarch.rpm gtkdialog-examples-0.8.3-1.fc21.noarch.rpm gtkdialog-0.8.3-1.fc21.src.rpm gtkdialog.i686: E: incorrect-fsf-address /usr/share/doc/gtkdialog/COPYING gtkdialog.i686: W: no-manual-page-for-binary gtkdialog gtkdialog.i686: W: install-file-in-docs /usr/share/doc/gtkdialog/INSTALL gtkdialog-doc.noarch: E: info-files-without-install-info-postin /usr/share/info/gtkdialog.info.gz gtkdialog-doc.noarch: E: info-files-without-install-info-postun /usr/share/info/gtkdialog.info.gz gtkdialog-examples.noarch: E: invalid-dependency /usr/local/bin/gtkdialog gtkdialog-examples.noarch: W: no-documentation gtkdialog-examples.noarch: W: devel-file-in-non-devel-package /usr/share/gtkdialog/examples/c_embedded/example01.c gtkdialog-examples.noarch: E: non-executable-script /usr/share/gtkdialog/examples/glade/glade-entries_functions.functions 0644L /bin/sh gtkdialog-examples.noarch: E: incorrect-fsf-address /usr/share/gtkdialog/examples/pfeme/COPYING-elementary-icons gtkdialog-examples.noarch: E: incorrect-fsf-address /usr/share/gtkdialog/examples/button/COPYING-elementary-icons gtkdialog-examples.noarch: E: wrong-script-interpreter /usr/share/gtkdialog/examples/miscellaneous/standalone_file /usr/local/bin/gtkdialog gtkdialog-examples.noarch: E: incorrect-fsf-address /usr/share/gtkdialog/examples/pfeme/COPYING-fast-forward-icons gtkdialog-examples.noarch: E: incorrect-fsf-address /usr/share/gtkdialog/examples/pfeme/COPYING-nuvola-icons gtkdialog-examples.noarch: E: incorrect-fsf-address /usr/share/gtkdialog/examples/togglebutton/COPYING-elementary-icons gtkdialog.src: W: invalid-url Source0: https://gtkdialog.googlecode.com/files/gtkdialog-0.8.3.tar.gz <urlopen error [Errno 101] Network is unreachable> 4 packages and 0 specfiles checked; 11 errors, 5 warnings. Requires -------- gtkdialog (rpmlib, GLIBC filtered): libX11.so.6 libXext.so.6 libatk-1.0.so.0 libc.so.6 libcairo.so.2 libfontconfig.so.1 libfreetype.so.6 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libgio-2.0.so.0 libglade-2.0.so.0 libglib-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpangoft2-1.0.so.0 libpthread.so.0 libvte.so.9 libxml2.so.2 rtld(GNU_HASH) gtkdialog-doc (rpmlib, GLIBC filtered): gtkdialog-examples (rpmlib, GLIBC filtered): /bin/bash /bin/sh /usr/local/bin/gtkdialog Provides -------- gtkdialog: gtkdialog gtkdialog(x86-32) gtkdialog-doc: gtkdialog-doc gtkdialog-examples: gtkdialog-examples Source checksums ---------------- https://gtkdialog.googlecode.com/files/gtkdialog-0.8.3.tar.gz : CHECKSUM(SHA256) this package : ff89d2d7f1e6488e5df5f895716ac1d4198c2467a2a5dc1f51ab408a2faec38e CHECKSUM(SHA256) upstream package : ff89d2d7f1e6488e5df5f895716ac1d4198c2467a2a5dc1f51ab408a2faec38e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -rvn gtkdialog-0.8.3-1.oj35.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -------------------------------- 1. Yes vte is missing on EPEL7 now. 2. I don't think that you need to split out example and doc subpackages, since gtkdialog is a dev tool for developers(junior level IMO), they want to use it with example in hand. 3. %makeinstall not allowed. 4. https://gtkdialog.googlecode.com/files/gtkdialog-0.8.3.tar.gz You should use a %{version} macro at least: https://gtkdialog.googlecode.com/files/gtkdialog-%{version}.tar.gz 5. Fix ALL issues above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review