https://bugzilla.redhat.com/show_bug.cgi?id=1071163 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Requires: %{name} = %{version}-%{release} --> Requires: %{name}%{?_isa} = %{version}-%{release} 2. Can you remove "#--" in the spec? 3. %description too long, please remember no longer than 80 chars per line. 4. %{__sed} --> sed; %{__chmod} --> chmod; %{__mkdir} --> mkdir 5. Drop rm -rf $RPM_BUILD_ROOT 6. %ifarch x86_64 %{__mkdir} -p $RPM_BUILD_ROOT/usr/lib cd $RPM_BUILD_ROOT/usr/lib; ln -s ../lib64/MAST %endif I don't think this is a good hack for multilib. 7. # MoarVM does not come with its own test suite I don't think you need to write this. 8. - add Group tag Ooops, you should drop group tags, they are not needed anymore: https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag 9. For devel package, a template: %package devel Summary: Development files for %{name} Requires: %{name}%{?_isa} = %{version}-%{release} %description devel This package contains libraries and header files for developing applications that use %{name}. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review