[Bug 1074714] Review Request: joomla - Joomla! is an award-winning open source CMS for building powerful websites

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074714



--- Comment #5 from Michael Schwendt <bugs.michael@xxxxxxx> ---
Re: comment 1

> /var -> %{_localstatedir}
> 
> /etc -> %{_sysconfdir}, also %config(noreplace).

Please, Christopher,

it has always been macro-madness in a spec file to replace /var with
%_localstatedir if nothing in the build process evaluates %_localstatedir.

Even if %configure and a compatible configure script were used, the packager
would still need to examine whether the build environment files used
%_localstatedir actually.

Where a build env uses paths starting with /var, it has always been
better/preferred to either hardcode /var or use %_var, if wanting to use macros
for consistency:
https://fedoraproject.org/wiki/Packaging:RPMMacros#Other_macros_and_variables_for_paths

And nowadays, the guidelines are more lax anyway, meaning it is not mandatory
to use long macro names if there is no benefit:
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]