[Bug 1074969] Review Request: perl-Config-Generator - rpm containing global variables used by the Config::Generator modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074969



--- Comment #3 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Alexandre Beche from comment #2)
> Does it works now?
Yes, it does.

Some comments on your package:

* Package fails to build:
error: Installed (but unpackaged) file(s) found:
   /usr/bin/yacg
   /usr/share/man/man1/yacg.1.gz

You need to add
%{_bindir}/yacg
%{_mandir}/man1/yacg*
or similar to %files

* Except of the "Require: perl(:MODULE_COMPAT*)", all "Requires: perl(*)"
should all be removed from the spec. 
RPM automatically generates the necessary Requires: itself.

* Unless you plan to support epel < 6, you can tighten up the spec-file by
removing many anachronims from the spec (%clean, rm -rf $RPM_BUILD_ROOT,
BuildRoot:, %defattr, etc.).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]