https://bugzilla.redhat.com/show_bug.cgi?id=1074129 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: 571389c9ab62d9d0dbae479460d8c2b5132de7467990198532b9f4845b9ecfe4). Ok. XS code presents, architecture dependent package is Ok. Summary verified from LZF.pm. Ok. Description verified from LZF.pm.Ok. TODO: The description is non-descriptive. It talks about bundling (that will not be true in Fedora) and about free for commercial usage (that should go into license). I'd like to see instead of these statements something useful like `this is Perl binding to LZF compression library'. Perl code license verified from COPYING. FIX: Bundled LZF sources (lzf_c.c, lzfP.h, lzf_c_best.c) are licensed under (BSD or GPLv2+). This must be declared in the License tag too. Or unbundle the code. FIX: Unbundle the LZF library (lzf_c.c, lzfP.h, lzf_c_best.c) and use system implementation (liblzf). Or obtain exception from Fedora Packaging Committee <https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries>. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Compress-LZF.spec ../SRPMS/perl-Compress-LZF-3.7-1.fc21.src.rpm ../RPMS/x86_64/perl-Compress-LZF-3.7-1.fc21.x86_64.rpm perl-Compress-LZF.src: W: spelling-error %description -l en_US memcpy -> memory perl-Compress-LZF.x86_64: W: spelling-error %description -l en_US memcpy -> memory perl-Compress-LZF.x86_64: E: incorrect-fsf-address /usr/share/doc/perl-Compress-LZF/COPYING.GNU 2 packages and 1 specfiles checked; 1 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Compress-LZF-3.7-1.fc21.x86_64.rpm drwxr-xr-x 2 root root 0 Mar 11 14:59 /usr/lib64/perl5/vendor_perl/Compress -rw-r--r-- 1 root root 4777 Aug 25 2013 /usr/lib64/perl5/vendor_perl/Compress/LZF.pm drwxr-xr-x 2 root root 0 Mar 11 14:59 /usr/lib64/perl5/vendor_perl/auto/Compress drwxr-xr-x 2 root root 0 Mar 11 14:59 /usr/lib64/perl5/vendor_perl/auto/Compress/LZF -rwxr-xr-x 1 root root 23696 Mar 11 14:59 /usr/lib64/perl5/vendor_perl/auto/Compress/LZF/LZF.so drwxr-xr-x 2 root root 0 Mar 11 14:59 /usr/share/doc/perl-Compress-LZF -rw-r--r-- 1 root root 244 Jun 1 2010 /usr/share/doc/perl-Compress-LZF/COPYING -rw-r--r-- 1 root root 6111 Jun 1 2010 /usr/share/doc/perl-Compress-LZF/COPYING.Artistic -rw-r--r-- 1 root root 17998 Jun 1 2010 /usr/share/doc/perl-Compress-LZF/COPYING.GNU -rw-r--r-- 1 root root 4650 Aug 25 2013 /usr/share/doc/perl-Compress-LZF/Changes -rw-r--r-- 1 root root 4691 Aug 25 2013 /usr/share/doc/perl-Compress-LZF/README -rw-r--r-- 1 root root 3758 Mar 11 14:59 /usr/share/man/man3/Compress::LZF.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Compress-LZF-3.7-1.fc21.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.18()(64bit) 1 perl(DynaLoader) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.18.2) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Compress-LZF-3.7-1.fc21.x86_64.rpm | sort | uniq -c 1 perl(Compress::LZF) = 3.7 1 perl-Compress-LZF = 3.7-1.fc21 1 perl-Compress-LZF(x86-64) = 3.7-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Compress-LZF-3.7-1.fc21.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6621625). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the `FIX' items, and provide new spec file. Resolution: NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review