[Bug 1069257] Review Request: fparser - Function parser library for C++

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069257



--- Comment #15 from Michael Schwendt <bugs.michael@xxxxxxx> ---
According to the FAQ both license texts need to be included if it's the LGPL
v3:

  https://www.gnu.org/licenses/gpl-faq.html#v3HowToUpgrade

Since probably not all developers are aware of that, once a project is found
that only includes the LGPL v3 terms, a bug report would be justified. Sort of
following
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

[...]

> fparser_gmpint.hh includes files from gmp-devel,

Can't confirm. I only see subdir includes and C++ stdlib:

$ grep \#include fparser/* -R
fparser/fparser_gmpint.hh:#include "fparser.hh"
fparser/fparser_gmpint.hh:#include "mpfr/GmpInt.hh"
fparser/fparser.hh:#include <string>
fparser/fparser.hh:#include <vector>
fparser/fparser.hh:#include <iostream>
fparser/fparser.hh:#include <complex>
fparser/fparser_mpfr.hh:#include "fparser.hh"
fparser/fparser_mpfr.hh:#include "mpfr/MpfrFloat.hh"
fparser/fpaux.hh:#include "fptypes.hh"
fparser/fpaux.hh:#include <cmath>
fparser/fpaux.hh:#include "mpfr/MpfrFloat.hh"
fparser/fpaux.hh:#include "mpfr/GmpInt.hh"
fparser/fpaux.hh:#include <complex>
fparser/fptypes.hh:#include "fpconfig.hh"
fparser/fptypes.hh:#include <cstring>
fparser/fptypes.hh:#include <map>
fparser/fptypes.hh:#include <vector>
fparser/fptypes.hh://#include "fpaux.hh"
fparser/mpfr/GmpInt.hh:#include <iostream>
fparser/mpfr/MpfrFloat.hh:#include <iostream>


> What do you think?

It's not a big issue. Either add the Requires or not would work. In my opinion,
currently it would be cleaner, if no such dependencies were added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]