[Bug 1074515] Review Request: passenger - Passenger Ruby web application server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1074515



--- Comment #2 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
First quick comment

- 4.0.38 is released ;)
- some cleanups : most command can be used directly no need for macro (%{_rm},
...)
- no need for Buildroot and rm -rf %{buildroot}
- bundled libeio => probably requires a FPC exception

About obsoletes,

Not needed for virtual provides, only for package
=> Obsoletes: rubygem(passenger) < 4.0.37
=> Obsoletes: rubygem-passenger%{?_isa} < 4.0.37

Issue with version:
Obsoletes: rubygem-passenger < 4.0.37
Provides:  rubygem-passenger = 4.0.37
Provides: rubygem-passenger%{?_isa} = 4.0.37

This is ok, but only for now.
It will only work if no update will never go in f<=20

Proposal
Obsoletes: rubygem-passenger < %{version}-%{release}
Provides:  rubygem-passenger = %{version}-%{release}
Provides: rubygem-passenger%{?_isa} = %{version}-%{release}

And use 2 as release, and add a comment in rubygem-passenger in f20 to never
use release > 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]