[Bug 1066633] Review Request: openstack-tripleo-heat-templates - Heat templates for TripleO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066633



--- Comment #3 from Steven Dake <sdake@xxxxxxxxxx> ---
James,

I recommend against using datarootdir macro and also using the %doc feature for
the reference templates.

Please have a look at:
https://github.com/sdake/fedora-reviews/blob/master/openstack-heat-templates/openstack-heat-templates.spec#L47

Please fix this rpmlint problem:
openstack-tripleo-heat-templates.src:8: W: mixed-use-of-spaces-and-tabs
(spaces: line 8, tab: line 1)

Please correct all of the problems Angus has pointed out and I'll provide a
final review.

Thanks!
-steve

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]