[Bug 728302] Review Request: pjproject - Libraries written in C language for building embedded/non-embedded VoIP applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=728302

Anthony Messina <amessina@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?                   |
                   |needinfo?(amessina@messinet |
                   |.com)                       |



--- Comment #73 from Anthony Messina <amessina@xxxxxxxxxxxx> ---
(In reply to Jared Smith from comment #72)
> (In reply to Anthony Messina from comment #71)
> > Asterisk 12 will fail to build if the pj/config_site.h file is not present :(
> > 
> > /usr/include/pj/config.h:287:28: fatal error: pj/config_site.h: No such file
> > or directory
> 
> Yuck -- I removed the file, because rpmlint was complaining about it being
> an empty file.  I guess instead of deleting it, I'll change it to be
> non-empty.
> 
> http://jsmith.fedorapeople.org/Packaging/pjproject/pjproject.spec
> http://jsmith.fedorapeople.org/Packaging/pjproject/pjproject-2.2-4.fc20.src.
> rpm
> 
> Anthony, can you test these and see if they work better for you in packaging
> up Asterisk 12?

For reference, I've merged in your changes to my own spec to build in a private
Koji instance.  I've also disabled building iLBC for now and updated the
no_third_party patch accordingly.  Note, I'm also still using alpha/post gittag
notations in the version to separate my package from the future upstream (for
now) and to ensure that future patches from Asterisk's devs can be easily
included.  The remainder of the spec file should be usable.

Using the files located here

https://messinet.com/rpms/browser/pjproject/?rev=521998e499bbc39b42daa6cf7125d5b200ed4a6b

I'm able to build pjproject without rpmlint errors.  I am also able to build
Asterisk 12.1.0 against this updated prjproject.

I was wondering if your patch for the FSF address was submitted upstream to
pjproject?  I ask because it appears like they updated the COPYING file in
their source, but not the header files.

Perhaps some of the Asterisk devs would help getting a --use-external-ilbc
patch upstream since they were able to get everything else they did upstream ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]