https://bugzilla.redhat.com/show_bug.cgi?id=1073978 Antonio Trande <anto.trande@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@xxxxxxxxx --- Comment #1 from Antonio Trande <anto.trande@xxxxxxxxx> --- Hi Adrien. You don't need to define Name, Version and Release macros because they are already defined. Vendor tag must not be used. SourceX tag is a complete link to the source archive. Prefix tag is unnecessary. Buildroot tag is used only for EPEL5 packages or for old Fedora releases (see http://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag and http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag). As Buildroot, %clean section is unnecessary for recent Fedora releases (http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean) like so %defattr line (http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review