https://bugzilla.redhat.com/show_bug.cgi?id=1026764 --- Comment #5 from Philip Withnall <philip@xxxxxxxxxxxxxxx> --- Updated spec file: http://people.collabora.co.uk/~pwith/packaging/uhttpmock.spec Updated SRPM URL: http://people.collabora.co.uk/~pwith/packaging/uhttpmock-0.2.0-1.fc19.src.rpm Latest Koji builds: • f19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6605664 • f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6605665 • f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6605666 (In reply to Cole Robinson from comment #4) > Unless you are planning on building for EPEL, you can drop the Group: tags: > > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag Removed. > rpmlint gives: > > uhttpmock.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libuhttpmock-0.0.so.0.0.1 /lib64/libgthread-2.0.so.0 > uhttpmock.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libuhttpmock-0.0.so.0.0.1 /lib64/libpthread.so.0 > > 'git grep gthread' and some poking seems to show that gthread doesn't appear > to be used at all, except in configure and the pkgconfig file. (I might be > missing something though, not too savvy here) Dropped upstream: https://gitorious.org/uhttpmock/uhttpmock/commit/45c22b046dff336113d7b812da6ada0675d4bcc7 This can get picked up in the RPM with the next release of uhttpmock (not yet made). > Mark the gtk-doc bits with %doc Fixed. > It seems inconsistent to use explicit file listing like: > > %{_datadir}/vala/vapi/libuhttpmock-%{uhm_api_version}.dep > > Mixed with wildcards like: > > %{_libdir}/*.so > > I'd recommend to standardize on using all explicit paths. Fixed. I kept a wildcard for the SO version. > It appears the package has tests, consider running them in a %check section > if it's safe to do so. Ah, excellent. Added, and they all pass. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review