[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=866265



--- Comment #22 from Michael Schwendt <bugs.michael@xxxxxxx> ---
> %package        devel
> Requires:       pkgconfig

pkgconfig deps are automatic for Fedora and EL6


> %package        data
> Summary:        Referential data for the %{name} library
> Group:          System Environment/Libraries

Just for anyone who might wonder about this group tag in the future: It's a
somewhat strange group for an optional data package, which is used by a lib but
is not a lib. There are no good alternatives in /usr/share/doc/rpm/GROUP
however, at most Applications/Databases, which wouldn't be better IMO.



Also just for completeness, "fedora-review -b 866265" reports 

  BSL (v1.0)
  ----------
  opentrep-0.6.0/test/parsers/full_calculator.cpp
  opentrep-0.6.0/test/parsers/parameter_parser.cpp

which only applies to test source code files.



> %package        data

It's possible to put an own "License: CC-BY-SA" tag into this subpackage.



/usr/bin/opentrep-config will still conflict, because of the line

  #libdir=@libdir@

that will contain the expanded libdir value. Easy to fix in the
opentrep-config.in template.



The Provides for the Python module libpyopentrep.so.0.6 are [potentially]
problematic: 
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

  $ rpm -qp --provides opentrep-0.6.0-1.fc20.x86_64.rpm 
  libopentrep.so.0.6()(64bit)
* libpyopentrep.so.0.6()(64bit)
  opentrep = 0.6.0-1.fc20
  opentrep(x86-64) = 0.6.0-1.fc20

Not a blocker.

  $ repoquery --whatprovides libpyopen\*
  $

But notice:

  $ repoquery --whatprovides libpy\*|wc -l
  70


> Note that the Python script has got a manual page,
> but can only be executed from the Python site-packages directory.
> I do not know how to solve that issue.

It could be moved into /usr/bin after deleting the sys.path.append lines which
are commented out anyway. Its Python module is stored in Python search path.


$ /usr/lib64/python2.7/site-packages/libpyopentrep/pyopentrep
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/libpyopentrep/pyopentrep", line 7,
in <module>
    import Travel_pb2
  File "/usr/lib64/python2.7/site-packages/libpyopentrep/Travel_pb2.py", line
4, in <module>
    from google.protobuf import descriptor as _descriptor
ImportError: No module named google.protobuf



Very basic runtime testing _without_ the -data subpackage being installed
causes the programs to abort:

  $ opentrep-dbmgr 
  POR file-path is: /usr/share/opentrep/data/por/ori_por_public.csv
  Xapian database filepath is: /tmp/opentrep/traveldb
  Log filename is: opentrep-dbmgr.log
  Creating the SQLite3 database may take a few minutes on some architectures
(and a few seconds on fastest ones)...
  terminate called after throwing an instance of
'OPENTREP::SQLDatabaseException'
  what():  Error when trying to retrieve 0-th row from the SQLite3
database:Cannot establish connection to the database. unable to open database
file
  Aborted (core dumped)

Only after installing the -data package, running opentrep-dbmgr
opentrep-indexer opentrep-searcher succeeds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]