[Bug 1070230] Review Request: python-django15 - A high-level Python Web framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1070230



--- Comment #2 from Matthias Runge <mrunge@xxxxxxxxxx> ---
Lars, thank you for your review!it's really appreciated and this one is a tough
one!

First of all, I'm very sorry,I should have provided a matching spec file to the
srpm!

Addressing the issues:

- I simply forgot to own %{python3_sitelib}/Django-%{version}-py?.?.egg/
(fixed)

- how to test: 
from pkg_resources import require
require("Django >=1.5")
import django
print django.VERSION
(or so)

from http://fedoraproject.org/wiki/Packaging:Python_Eggs#Multiple_Versions
"It is highly recommended that any such compatibility packages install a
README.fedora file explaining how to use this module. "
(fixed)

- {__python} vs. {__python2}: I added a macro to the top:
%{!?__python2:%global __python2 %{__python}} (to make __python2 run on rhel6
and changed __python to __python2

- I know about all those duplicate files. those are language files. When not
listing them, it saves about 200 lines (or so) in the spec file. Will add them
back.

- the bundled eggs are (currently) required for tests. Will remove them, or
will take care not to distribute them in the RPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]