https://bugzilla.redhat.com/show_bug.cgi?id=1055837 --- Comment #6 from Antonio Trande <anto.trande@xxxxxxxxx> --- - This is not latest version. Exists a 3.3.1 that contains changes useful just for Windows systems. The 3.3 release (commit number 32522087f63eab536d34c9a9a281cf50d1a7d5a0) is available here https://github.com/simbody/simbody/archive/Simbody-3.3.tar.gz In that case, commit/shortcommit macros are not necessary. Use: Name: simbody Version: 3.3 Release: 1%{?dist} Summary: Multi-body Physics API ... Source0: https://github.com/simbody/simbody/archive/Simbody-3.3.tar.gz - Some files are with license MIT: SimTKcommon/src/gmx_atomic.h SimTKmath/tests/IntegratorTestFramework.h SimTKmath/tests/PendulumSystem.h Simbody/Visualizer/VisualizerGUI/glut32/ This is with "Plublic domain" SimTKcommon/Polynomial/src/rpoly.cpp See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario Please, check also all licenses of the files reported on attached list. - Remove all bundled files. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries Check these sub-directories: Integrators/src/CPodes/sundials SimTKmath/Optimizers/src/IpOpt - Change -DSimTK_INSTALL_PREFIX=/usr to -DSimTK_INSTALL_PREFIX=%{_prefix} - Check and fix these warning about doxygen Warning: Tag `SYMBOL_CACHE_SIZE' at line 346 of file /builddir/build/BUILD/simbody-32522087f63eab536d34c9a9a281cf50d1a7d5a0/build/Doxyfile has become obsolete. To avoid this warning please remove this line from your configuration file or upgrade it using "doxygen -u" Warning: doxygen no longer ships with the FreeSans font. You may want to clear or change DOT_FONTNAME. Otherwise you run the risk that the wrong font is being used for dot generated graphs. warning: source /builddir/build/BUILD/simbody-32522087f63eab536d34c9a9a281cf50d1a7d5a0/SimTKcommon/doc/images is not a readable file or directory... skipping. - Maybe, better 'make %{?_smp_mflags} -C build' - Why do not make example files ? Read Simbody/examples/README.txt and Simbody/examples/README_makefile.txt # Move examples to /usr/share rm -rf %{buildroot}/usr/examples/bin mkdir -p %{buildroot}%{_datadir}/simbody mv %{buildroot}/usr/examples %{buildroot}%{_datadir}/simbody/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "MIT/X11 (BSD like)", "*No copyright* Public domain", "Unknown or generated", "zlib/libpng". 307 files have unknown license. Detailed output of licensecheck in /home/sagitter/1055837-simbody/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in simbody-doc [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 9216000 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: simbody-3.3-1.fc21.i686.rpm simbody-devel-3.3-1.fc21.i686.rpm simbody-doc-3.3-1.fc21.i686.rpm simbody-3.3-1.fc21.src.rpm simbody.i686: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti simbody.i686: W: spelling-error %description -l en_US multi -> mulch, mufti simbody.i686: W: spelling-error %description -l en_US neuro -> euro, neuron, negro simbody.i686: W: shared-lib-calls-exit /usr/lib/libSimTKmath.so.3.3 exit@GLIBC_2.0 simbody.i686: W: no-manual-page-for-binary VisualizerGUI simbody-devel.i686: W: no-documentation simbody.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti simbody.src: W: spelling-error %description -l en_US multi -> mulch, mufti simbody.src: W: spelling-error %description -l en_US neuro -> euro, neuron, negro 4 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint simbody-devel simbody simbody-doc simbody-devel.i686: W: no-documentation simbody.i686: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti simbody.i686: W: spelling-error %description -l en_US multi -> mulch, mufti simbody.i686: W: spelling-error %description -l en_US neuro -> euro, neuron, negro simbody.i686: W: unused-direct-shlib-dependency /usr/lib/libSimTKcommon.so.3.3 /lib/libblas.so.3 simbody.i686: W: unused-direct-shlib-dependency /usr/lib/libSimTKcommon.so.3.3 /lib/librt.so.1 simbody.i686: W: unused-direct-shlib-dependency /usr/lib/libSimTKmath.so.3.3 /lib/librt.so.1 simbody.i686: W: shared-lib-calls-exit /usr/lib/libSimTKmath.so.3.3 exit@GLIBC_2.0 simbody.i686: W: unused-direct-shlib-dependency /usr/lib/libSimTKsimbody.so.3.3 /lib/libblas.so.3 simbody.i686: W: unused-direct-shlib-dependency /usr/lib/libSimTKsimbody.so.3.3 /lib/libdl.so.2 simbody.i686: W: no-manual-page-for-binary VisualizerGUI 3 packages and 0 specfiles checked; 0 errors, 11 warnings. # echo 'rpmlint-done:' Requires -------- simbody-devel (rpmlib, GLIBC filtered): cmake libSimTKcommon.so.3.3 libSimTKmath.so.3.3 libSimTKsimbody.so.3.3 simbody(x86-32) simbody (rpmlib, GLIBC filtered): /sbin/ldconfig libGL.so.1 libGLU.so.1 libICE.so.6 libSM.so.6 libSimTKcommon.so.3.3 libSimTKmath.so.3.3 libSimTKsimbody.so.3.3 libX11.so.6 libXext.so.6 libXi.so.6 libXmu.so.6 libblas.so.3 libc.so.6 libdl.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgcc_s.so.1(GCC_4.0.0) libglut.so.3 liblapack.so.3 libm.so.6 libpthread.so.0 librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(CXXABI_1.3.1) rtld(GNU_HASH) simbody-doc (rpmlib, GLIBC filtered): Provides -------- simbody-devel: simbody-devel simbody-devel(x86-32) simbody: libSimTKcommon.so.3.3 libSimTKmath.so.3.3 libSimTKsimbody.so.3.3 simbody simbody(x86-32) simbody-doc: simbody-doc simbody-doc(x86-32) Source checksums ---------------- https://github.com/simbody/simbody/archive/32522087f63eab536d34c9a9a281cf50d1a7d5a0/simbody-3.3-3252208.tar.gz : CHECKSUM(SHA256) this package : 9fe212df8ba2c080e156111833c6635d83aa5428650ae422d583be857abd2185 CHECKSUM(SHA256) upstream package : 9fe212df8ba2c080e156111833c6635d83aa5428650ae422d583be857abd2185 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-i386 -b 1055837 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review