[Bug 550360] Review Request: dnstop - Displays information about DNS traffic on your network

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=550360



--- Comment #10 from Denis Fateyev <denis@xxxxxxxxxxx> ---
Firstly, I thought to apply cosmetic corrections to EPEL branches only, but
they actually can be befenit for all branches.

Could you apply this to original spec? It's only regarding that we need
BuildRoot, "clean" section and BuildRoot removal only in RHEL5.

--- dnstop.spec    2014-03-04 18:20:04.000000000 +0600
+++ dnstop.spec    2014-03-04 18:59:25.000000000 +0600
@@ -1,6 +1,6 @@
 Name:           dnstop
 Version:        20121017
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Displays information about DNS traffic on your network
 Group:          Applications/System
 License:        BSD
@@ -12,7 +12,7 @@
 # Also, check read(2) for entropy data and abort on short reads.
 Patch0:         dnstop-20121017-fix-warnings.diff

-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+%{?el5:BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)}
 BuildRequires:  libpcap-devel
 BuildRequires:  ncurses-devel

@@ -40,16 +40,19 @@


 %install
+%if 0%{?el5}
 rm -rf $RPM_BUILD_ROOT
-
+%endif
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man8

 make install DESTDIR=$RPM_BUILD_ROOT


+%if 0%{?el5}
 %clean
 rm -rf $RPM_BUILD_ROOT
+%endif


 %files
@@ -60,6 +63,9 @@


 %changelog
+* Mon Mar 03 2014 Denis Fateyev <denis@xxxxxxxxxxx> - 20121017-3
+- Spec cleanup, epel branches
+
 * Sat Aug 03 2013 Fedora Release Engineering <rel-eng@xxxxxxxxxxxxxxxxxxxxxxx>
- 20121017-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]