https://bugzilla.redhat.com/show_bug.cgi?id=1066238 --- Comment #13 from Ian Wienand <iwienand@xxxxxxxxxx> --- Thanks for the review! (In reply to Matthias Runge from comment #11) > - please don't approve packages containing rpm errors!, Feb 20th, was a > Thursday, the comment was made on Feb 19th. > - a full changelog is required, what happened with version -1? I may have misunderstood comment #7; fixed now > - the package does NOT meet the packaging guidelines ( %{__python} > deprecated) > Ian, please change %{__python} -> %{__python2} Done per packaging page > - remove %defattr from files section Done. I wasn't sure on this; rpmlint complained about it and [1] suggested it might be needed on RHEL/EPEL to me. > - the package does NOT build on rawhide in koji: > Please add BuildRequires: python-futures Sorry, failure of my testing. Should work, tested with [2] --- Spec URL: https://raw.github.com/ianw/python-trollius/master/python-trollius.spec SRPM URL: http://people.redhat.com/~iwienand/python-trollius/python-trollius-0.1.5-3.fc19.src.rpm Description: A port of the Tulip asyncio module to Python 2 Fedora Account System Username: iwienand --- [1] http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/Packagers_Guide/sect-Packagers_Guide-Creating_a_Basic_Spec_File.html [2] https://koji.fedoraproject.org/koji/taskinfo?taskID=6592911 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review