[Bug 1071581] Review Request: python-wikitools - Python package for interacting with a MediaWiki wiki

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1071581



--- Comment #2 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
Few issues from looking at the spec files.

* BuildRequires: python2-devel (or python3-devel) should be present.

https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

* Avoid INSTALLED_FILES. This, as per my understanding, causes permissions
problems.

Quoting from https://fedoraproject.org/wiki/Packaging:Python - 

"Warning (medium size).png
Avoid INSTALLED_FILES
python's distutils has an INSTALLED_FILES feature that lists which files are
installed when you run python setup.py install. Do not use it for packaging as
that will not list the directories which need to be specified in the %files
section as well. Using globs in the %files section is simpler and safer."

* BUILDROOT tag is not needed.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRoot_tag

* Release: 2%{?dist} should be present. Dist tag is missing. While not strictly
needed, please consider including the tag.

* %clean is present. According to guidelines, %clean should not be present.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25clean

Of course, all this is from the perspective of Fedora (as mentioned in the spec
file). Some of the comments above are not applicable if used in the context of
EL5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]