[Bug 1066238] Review Request: python-trollius - A port of the Tulip asyncio module to Python 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1066238

Matthias Runge <mrunge@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrunge@xxxxxxxxxx
              Flags|fedora-review+              |



--- Comment #11 from Matthias Runge <mrunge@xxxxxxxxxx> ---
some quick notes here:
- please don't approve packages containing rpm errors!, Feb 20th, was a
Thursday, the comment was made on Feb 19th.
- a full changelog is required, what happened with version -1?
- the package does NOT meet the packaging guidelines ( %{__python} deprecated)
Ian, please change %{__python} -> %{__python2}
- remove %defattr from files section
- the package does NOT build on rawhide in koji:

+ TOXENV=py27
+ /usr/bin/python setup.py test
running test
Searching for futures
Reading https://pypi.python.org/simple/futures/
Download error on https://pypi.python.org/simple/futures/: [Errno -2] Name or
service not known -- Some packages may not be found!
Couldn't find index page for 'futures' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service
not known -- Some packages may not be found!
No local packages or download links found for futures
error: Could not find suitable distribution for Requirement.parse('futures')
error: Bad exit status from /var/tmp/rpm-tmp.dQCwIq (%check)
RPM build errors:
    bogus date in %changelog: Tue Feb 20 2014  <iwienand@xxxxxxxxxx> - 0.1.5-2
    Bad exit status from /var/tmp/rpm-tmp.dQCwIq (%check)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps 
builddir/build/SPECS/python-trollius.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line
70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 376, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps 
builddir/build/SPECS/python-trollius.spec']
LEAVE do --> EXCEPTION RAISED


Please add BuildRequires: python-futures

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]