https://bugzilla.redhat.com/show_bug.cgi?id=1028743 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Update systemd scriptlets. https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd 2. Users & Groups template: https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation 3. Conditional lines for different init systems please if you want to maintain it in one spec. Currently they are broken. 4. No -sysvinit package please, handle them in conditional lines. Or turn it into %_bindir. 5. %{buildroot}/ --> %{buildroot} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review