[Bug 1071653] Review Request: kmscon - KMS/DRM based System Console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1071653



--- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> ---
1. Missing:

checking for docbook manpages stylesheet... no --> docbook-xsl

2. renderer_pixman_enabled=no, any details?

3. %description:

"See kmscon(1) man-page for usage information."

You can drop this IMO.

4. Drop this:

rm -rf $RPM_BUILD_ROOT

5. BuildRequires: systemd-units

--> BuildRequires: systemd

6. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

7. Silent build, please append V=1 or --disable-silent-rules to %configure.

8. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

-->

find $RPM_BUILD_ROOT -name '*.la' -delete -print

Therefore it will be easier to track which file has been deleted.

9. cpio: gcc-4.8.2-20140120/libgcc/config/i386/crtfastmath.c: Cannot stat: No
such file or directory
cpio: gcc-4.8.2-20140120/obj-i686-redhat-linux/gcc/include/cpuid.h: Cannot
stat: No such file or directory
cpio: gcc-4.8.2-20140120/obj-i686-redhat-linux/i686-redhat-linux/libgcc: Cannot
stat: No such file or directory

Suspicious. debuginfo related maybe.
-------------------------

Please fix all above and provide me the new SPEC & SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]