[Bug 1063040] Review Request: rubygem-em-socksify - Transparent proxy support for any EventMachine protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1063040



--- Comment #3 from Mo Morsi <mmorsi@xxxxxxxxxx> ---
Hey Nitesh, looked at the updated package

- As w/ the others please rename spec to 'rubygem-em-socksify.spec'

- You will need to add "BuildRequires: rubygem(eventmachine) >= 1.0.0.beta4"
along w/ the other BuildRequires

- .gitignore should be removed or excluded

- "Updated as per the comments" should be changed to something more descriptive

- The %check command should be "rspec -Ilib spec"

- You will need to sed out bundler in spec/helper.rb before running rspec

I made these changes change and ran the build locally and on koji but it failed
in both environments:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6587064
http://kojipkgs.fedoraproject.org//work/tasks/7065/6587065/build.log

I suspect this is the culprit

https://github.com/igrigorik/em-socksify/issues/10

Admittedly didn't fully investigate but it looks like the spec is requiring an
external proxy to work. This wouldn't work for Fedora (external connections
aren't permitted in mock/koji) so we could:

- try to get the issue resolved upstream (add a comment to that issue)

- patch the spec/socksify_spec.rb ourselves to make it compatible

- simply skip the specs (since there are only 2 tests and they both connect to
external services)

Feel free to pick a solution and implement or we can discuss more here or on
IRC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]