https://bugzilla.redhat.com/show_bug.cgi?id=1013095 --- Comment #6 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- There are some issues with the package. Please see the detailed review below. If I can clarify any points, please let me know. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Packages have proper BuildRequires/Requires on jpackage-utils ---> BuildRequires and cube-java has Requires: jpackage-utils - looks fine. Does cube also require this? Requires does not show that below. - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in cube See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ---> I don't why fedora-review is saying this when it **is** using the java plugin! - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2068480 bytes in 29 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in cube See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 696 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1013095-cube/licensecheck.txt ---> This is fine. The subset I checked all have BSD license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build Maven: [-]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Old add_to_maven_depmap macro is not being used ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. ---> Reason for this is given in the spec file. Evaluating. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cube-doc , cube-java ---> cube-doc is fine, but is this important for cube-java? [x]: Package functions as described. [!]: Latest version is packaged. ---> Latest version is 4.2.2 released on Feb 26. Please update. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. ---> Please do a koji scratch build. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Packages are noarch unless they use JNI Note: cube subpackage is not noarch. Please verify manually [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2078720 bytes in /usr/share ---> Is this because there is no javadoc subpackage? [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cube-4.2.1-2.fc21.x86_64.rpm cube-devel-4.2.1-2.fc21.x86_64.rpm cube-doc-4.2.1-2.fc21.noarch.rpm cube-java-4.2.1-2.fc21.noarch.rpm cube-4.2.1-2.fc21.src.rpm cube.x86_64: W: name-repeated-in-summary C CUBE cube.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable cube.x86_64: W: spelling-error %description -l en_US Scalability -> Availability, Sociability, Implacability cube.x86_64: W: shared-lib-calls-exit /usr/lib64/libcube4w.so.4.2.0 exit@GLIBC_2.2.5 cube.x86_64: W: shared-lib-calls-exit /usr/lib64/libcube4.so.4.2.0 exit@GLIBC_2.2.5 $ rpmlint -I shared-lib-calls-exit shared-lib-calls-exit: This library package calls exit() or _exit(), probably in a non-fork() context. Doing so from a library is strongly discouraged - when a library function calls exit(), it prevents the calling program from handling the error, reporting it to the user, closing files properly, and cleaning up any state that the program has. It is preferred for the library to return an actual error code and let the calling program decide how to handle the situation. ---> Please investigate. cube.x86_64: W: no-manual-page-for-binary cube_remap2 cube.x86_64: W: no-manual-page-for-binary cube3to4 cube.x86_64: W: no-manual-page-for-binary cube_topoassist cube.x86_64: W: no-manual-page-for-binary cube_is_empty cube.x86_64: W: no-manual-page-for-binary tau2cube cube.x86_64: W: no-manual-page-for-binary cube_score cube.x86_64: W: no-manual-page-for-binary cube_rank cube.x86_64: W: no-manual-page-for-binary cube_calltree cube.x86_64: W: no-manual-page-for-binary cube_nodeview cube.x86_64: W: no-manual-page-for-binary cube_merge cube.x86_64: W: no-manual-page-for-binary cube_info cube.x86_64: W: no-manual-page-for-binary cube_cmp cube.x86_64: W: no-manual-page-for-binary cube_sanity cube.x86_64: W: no-manual-page-for-binary cube cube.x86_64: W: no-manual-page-for-binary cube4to3 cube.x86_64: W: no-manual-page-for-binary cube_inclusify cube.x86_64: W: no-manual-page-for-binary cube_dump cube.x86_64: W: no-manual-page-for-binary cube_stat cube.x86_64: W: no-manual-page-for-binary cube_mean cube.x86_64: W: no-manual-page-for-binary cube_test cube.x86_64: W: no-manual-page-for-binary cube_part cube.x86_64: W: no-manual-page-for-binary cube_canonize cube.x86_64: W: no-manual-page-for-binary cube_clean cube.x86_64: W: no-manual-page-for-binary cube_diff cube.x86_64: W: no-manual-page-for-binary cube_exclusify cube.x86_64: W: no-manual-page-for-binary cube_regioninfo cube.x86_64: W: no-manual-page-for-binary cube_cut cube.x86_64: W: no-manual-page-for-binary cube_derive cube-devel.x86_64: W: no-documentation cube-devel.x86_64: W: no-manual-page-for-binary cube-config cube-devel.x86_64: W: no-manual-page-for-binary cube-config-backend cube-devel.x86_64: W: no-manual-page-for-binary cube-config-frontend cube-java.noarch: W: no-documentation cube.src: W: name-repeated-in-summary C CUBE cube.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable cube.src: W: spelling-error %description -l en_US Scalability -> Availability, Sociability, Implacability cube.src:63: E: hardcoded-library-path in /usr/lib $ rpmlint -I hardcoded-library-path hardcoded-library-path: A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. ---> This is a problem. But, I think this is because of the sed call in the spec file, in which case, it **might** be fine? Must be looked at. 5 packages and 0 specfiles checked; 1 errors, 41 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint cube-devel cube-java cube-doc cube cube-devel.x86_64: W: no-documentation cube-devel.x86_64: W: no-manual-page-for-binary cube-config cube-devel.x86_64: W: no-manual-page-for-binary cube-config-backend cube-devel.x86_64: W: no-manual-page-for-binary cube-config-frontend cube-java.noarch: W: no-documentation cube.x86_64: W: name-repeated-in-summary C CUBE cube.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable cube.x86_64: W: spelling-error %description -l en_US Scalability -> Availability, Sociability, Implacability cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_write_sev_row cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_write_sev_row_of_doubles cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_create cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_set_known_cnodes_for_metric cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_write_sev_row_of_uint64 cube.x86_64: W: undefined-non-weak-symbol /usr/lib64/libcubewriter4.so.4.2.0 cube_free $ rpmlint -I undefined-non-weak-symbol undefined-non-weak-symbol: The binary contains undefined non-weak symbols. This may indicate improper linkage; check that the binary has been linked as expected. ---> Please take a look at this. cube.x86_64: W: shared-lib-calls-exit /usr/lib64/libcube4w.so.4.2.0 exit@GLIBC_2.2.5 cube.x86_64: W: shared-lib-calls-exit /usr/lib64/libcube4.so.4.2.0 exit@GLIBC_2.2.5 cube.x86_64: W: no-manual-page-for-binary cube_remap2 cube.x86_64: W: no-manual-page-for-binary cube3to4 cube.x86_64: W: no-manual-page-for-binary cube_topoassist cube.x86_64: W: no-manual-page-for-binary cube_is_empty cube.x86_64: W: no-manual-page-for-binary tau2cube cube.x86_64: W: no-manual-page-for-binary cube_score cube.x86_64: W: no-manual-page-for-binary cube_rank cube.x86_64: W: no-manual-page-for-binary cube_calltree cube.x86_64: W: no-manual-page-for-binary cube_nodeview cube.x86_64: W: no-manual-page-for-binary cube_merge cube.x86_64: W: no-manual-page-for-binary cube_info cube.x86_64: W: no-manual-page-for-binary cube_cmp cube.x86_64: W: no-manual-page-for-binary cube_sanity cube.x86_64: W: no-manual-page-for-binary cube cube.x86_64: W: no-manual-page-for-binary cube4to3 cube.x86_64: W: no-manual-page-for-binary cube_inclusify cube.x86_64: W: no-manual-page-for-binary cube_dump cube.x86_64: W: no-manual-page-for-binary cube_stat cube.x86_64: W: no-manual-page-for-binary cube_mean cube.x86_64: W: no-manual-page-for-binary cube_test cube.x86_64: W: no-manual-page-for-binary cube_part cube.x86_64: W: no-manual-page-for-binary cube_canonize cube.x86_64: W: no-manual-page-for-binary cube_clean cube.x86_64: W: no-manual-page-for-binary cube_diff cube.x86_64: W: no-manual-page-for-binary cube_exclusify cube.x86_64: W: no-manual-page-for-binary cube_regioninfo cube.x86_64: W: no-manual-page-for-binary cube_cut cube.x86_64: W: no-manual-page-for-binary cube_derive 4 packages and 0 specfiles checked; 0 errors, 44 warnings. # echo 'rpmlint-done:' Requires -------- cube-devel (rpmlib, GLIBC filtered): /bin/bash cube(x86-64) libcube4.so.4()(64bit) libcube4w.so.4()(64bit) libcubewriter4.so.4()(64bit) cube-java (rpmlib, GLIBC filtered): cube jpackage-utils cube-doc (rpmlib, GLIBC filtered): /bin/sh cube (rpmlib, GLIBC filtered): /bin/sh /sbin/ldconfig libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libc.so.6()(64bit) libcube4.so.4()(64bit) libdbus-1.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) Provides -------- cube-devel: cube-devel cube-devel(x86-64) cube-java: cube-java cube-doc: cube-doc cube: application() application(CUBE.desktop) cube cube(x86-64) libcube4.so.4()(64bit) libcube4w.so.4()(64bit) libcubewriter4.so.4()(64bit) mimehandler(application/cube) Source checksums ---------------- http://apps.fz-juelich.de/scalasca/releases/cube/4.2/dist/cube-4.2.1.tar.gz : CHECKSUM(SHA256) this package : c24c6e1e2bc6fcf89a2a68d78c7baadbcc7100ea91e9c04c02696dafa0cd1f49 CHECKSUM(SHA256) upstream package : c24c6e1e2bc6fcf89a2a68d78c7baadbcc7100ea91e9c04c02696dafa0cd1f49 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1013095 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++ Disabled plugins: Python, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review