[Bug 1065685] Review Request: rubygem-unicorn - Rack HTTP server for fast clients and Unix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1065685



--- Comment #2 from Achilleas Pipinellis <axilleas@xxxxxxxxxxx> ---
Ok, here are some comments.

- Use `cp -pa` to preserve timestamps, currently you do `cp -a`.

- rpmlint complains about: `No known owner of
/usr/share/gems/gems/unicorn-4.8.2/bin, /usr/lib64/gems/ruby/unicorn-4.8.2`.
Could it be that you should also include %{gem_instdir}/bin/ and
%{gem_extdir_mri}/lib under %files as well? Actually, I haven't really
understood how the dir ownership is defined. If I put a folder under %files it
includes all its subfolders as well, right?

- You don't exclude %{gem_cache}.

- rpmlint complains with `W: no-soname
/usr/lib64/gems/ruby/unicorn-4.8.2/lib/unicorn_http.so`. I have no idea what
this means and `rpmlint -I` doesn't give any info. Safe to ignore?

- Minor but fixable :) `W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab:
line 97)`

- E: specfile-error -e:1:in `<main>': Use RbConfig instead of obsolete and
deprecated Config. Epel6 uses ruby1.8 which I assume uses Config so it's safe
to ignore?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]