https://bugzilla.redhat.com/show_bug.cgi?id=1067002 Angus Thomas <athomas@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |athomas@xxxxxxxxxx --- Comment #7 from Angus Thomas <athomas@xxxxxxxxxx> --- Hi. I'm doing an unofficial review On the spec file, %{__python} and %{python_sitelib} are deprecated in favour of %{__python2} and %{python2_sitelib} Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /tmp/instack/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x-]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [-]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python See the note above about deprecated macros [x]: Package contains BR: python2-devel or python3-devel [-]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Since you're the upsteam, this should be possible to arrange ;-) [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: instack-0.0.2-1.fc20.noarch.rpm instack-0.0.2-1.fc20.src.rpm instack.noarch: W: spelling-error Summary(en_US) diskimage -> disk image, disk-image, disparage instack.noarch: W: spelling-error %description -l en_US diskimage -> disk image, disk-image, disparage instack.noarch: W: spelling-error %description -l en_US openstack -> open stack, open-stack, opens tack instack.noarch: W: spelling-error %description -l en_US tripleo -> triple, triples, triplet instack.noarch: W: no-manual-page-for-binary instack instack.src: W: spelling-error Summary(en_US) diskimage -> disk image, disk-image, disparage instack.src: W: spelling-error %description -l en_US diskimage -> disk image, disk-image, disparage instack.src: W: spelling-error %description -l en_US openstack -> open stack, open-stack, opens tack instack.src: W: spelling-error %description -l en_US tripleo -> triple, triples, triplet instack.src: W: invalid-url Source0: https://github.com/slagle/instack/releases/download/0.0.2/instack-0.0.2.tar.gz HTTP Error 403: Forbidden 2 packages and 0 specfiles checked; 0 errors, 10 warnings. Not sure what caused this. The URL works OK with wget. Is this the intented cononical upsteam repo? Rpmlint (installed packages) ---------------------------- # rpmlint instack instack.noarch: W: spelling-error Summary(en_US) diskimage -> disk image, disk-image, disparage instack.noarch: W: spelling-error %description -l en_US diskimage -> disk image, disk-image, disparage instack.noarch: W: spelling-error %description -l en_US openstack -> open stack, open-stack, opens tack instack.noarch: W: spelling-error %description -l en_US tripleo -> triple, triples, triplet instack.noarch: W: no-manual-page-for-binary instack 1 packages and 0 specfiles checked; 0 errors, 5 warnings. # echo 'rpmlint-done:' Requires -------- instack (rpmlib, GLIBC filtered): /bin/bash /usr/bin/python diskimage-builder python(abi) python-argparse Provides -------- instack: instack Source checksums ---------------- https://github.com/slagle/instack/releases/download/0.0.2/instack-0.0.2.tar.gz : CHECKSUM(SHA256) this package : 53835862d103256c7ba040324df6ef035cda52fcebea99a3f4b832b52f8fe267 CHECKSUM(SHA256) upstream package : 53835862d103256c7ba040324df6ef035cda52fcebea99a3f4b832b52f8fe267 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --rpm-spec -n /home/athomas/rpmbuild/SRPMS/instack-0.0.2-1.fc20.src.rpm Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review