https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Lokesh Mandvekar <lsm5@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lsm5@xxxxxxxxxx --- Comment #2 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- Hi Jeff, I'm not sure if the noarch for rhel >= 7 would work right now. Last time I checked, stuff was failing for some arch for rhel7 (I think ppc64). So I had noarch only for fedora >= 19. Did 'go test' work for you without specifying GOPATH? IIRC, it failed for me sometime back, and I used this: GOPATH=%{buildroot}/%{gopath} go test %{import_path}/capability (line 45 http://pkgs.fedoraproject.org/cgit/golang-github-syndtr-gocapability.git/tree/golang-github-syndtr-gocapability.spec) some minor things to consider (no biggie), for upstreams using git I've used 'shortcommit' (http://pkgs.fedoraproject.org/cgit/golang-github-gorilla-context.git/tree/golang-github-gorilla-context.spec) and for those using hg I've used 'shortrev' (http://pkgs.fedoraproject.org/cgit/golang-bitbucket-kardianos-osext.git/tree/golang-bitbucket-kardianos-osext.spec). The shortrev and abbrevrev could perhaps be replaced with a single shortcommit here and it could be used in the release tag too. (Again, this is just the current state of existing golang-* packages and _not_ a guideline.). HTH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review