https://bugzilla.redhat.com/show_bug.cgi?id=1069988 --- Comment #9 from Christopher Meng <cickumqt@xxxxxxxxx> --- 0. Not all issues solved pointed out by Michael and me. 1. Please cleanup the %attr, too many. 2. Systemd scriptlet is still not correct. Please read carefully. 3. ### Build our documentaiton cd %{name}-core make %{?_smp_mflags} dox --> make -C %{name}-core dox %{?_smp_mflags} 4. %post core if [ "$1" = "2" ]; then %if 0%{?rhel} >= 7 || 0%{?fedora} >= 20 %systemd_postun systemctl condrestart %{name}.service %else %{_initrddir}/%{name} condrestart &>/dev/null || %endif Why does postun scripet appear in %post section? 5. Do we need this? else %logmsg "User \"%{apacheuser}\" does not exist and is not added to group \"%{naemongroup}\". Sending commands to %{name} from the CGIs is not possible." fi 6. Conflicts: thruk What? 7. Requires(preun): %{name}-thruk-libs = %{version}-%{release} Requires(post): %{name}-thruk-libs = %{version}-%{release} ?? 8. %description thruk This package contains the thruk gui for %{name} Append dot at the last line. 9. %files devel %attr(-,root,root) %{_includedir}/%{name}/ %attr(-,root,root) %{_libdir}/%{name}/libnaemon.a %attr(-,root,root) %{_libdir}/%{name}/libnaemon.la Not allowed. 10. %attr(0644,root,root) %{_libdir}/%{name}/livestatus.o Object file? 11. BuildRequires: gd-devel > 1.8 BuildRequires: gd Duplicate. Should use -devel only. 12. configure --without-tests \ Recently regarding the tests in RPM has been discussed heatedly, please tell us the reason. 13. CFLAGS="%{mycflags} -Wformat" LDFLAGS="$CFLAGS" No %{optflags} used, no %{__global_ldflags} used. 14. Fedora packages have -doc subpackage for documentation. Your opinion? 15. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6579341 I just found huge tons of bundled perl modules. And this cause the final RPM provides conflicts with system. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review