[Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1058765



--- Comment #4 from Will Benton <willb@xxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #2)
> Thanks for the review.
> 
> I've pushed new spec that fixes your issues (no new SRPM yet):
> 
> https://raw.github.com/hroncok/SPECS/master/mono-cecil.spec
> 
> I tried to run the tests by nunit, but so far I have no success, could you
> give me a hand with it please? I have no idea, how should I invoke it in the
> right way.

I've taken a look at this; unfortunately, I'm not a Mono expert and can find no
other packages that use nunit (or nant, which depends on nunit) in their
builds!  It looks like you'll need to compile the projects in Test and
rocks/Test before running any tests, but actually running the tests from the
given configuration file (I used "nunit-console Mono.Cecil.nunit") fails
because some symbol files and libraries aren't where they are expected.

If you could reach out to upstream and ask how they run tests as part of their
CI, that would probably be helpful.  If it's going to be a lot of work to get
the tests running, though, I won't hold up the review just because of a missing
%check.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]