https://bugzilla.redhat.com/show_bug.cgi?id=1069335 --- Comment #12 from James Slagle <jslagle@xxxxxxxxxx> --- (In reply to Steven Dake from comment #8) > James, > > It is typically the packagers responsibility to diagnose and fix the rpmlint > warnings, but as the package reviewer, you have an opportunity to provide > guidance about what you would recommend changing to fix the rpmlint > problems. Many of those errors and warnings cannot be ignored. If you as > the package reviewer think they can be ignored, it is your responsibility to > actually verify that is the case. It is the packagers responsibility to > defend any decisions to ignore rpmlint warnings. One cool thing about being > a packager is two brains working together > 2 brains working separately. > Please have a more detailed look at the rpmlint warnings and errors and > comment in detail. > > Regards, > -steve I was using the other OpenStack packages already in rdo to determine what I thought was ok to allow here. Here's my deeper feedback on the SRPM lint: Rpmlint ------- Checking: openstack-ironic-2014.1-b2.2.fc21.noarch.rpm openstack-ironic-2014.1-b2.2.fc21.src.rpm openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.conf openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/policy.json openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-deploy-helper.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-images.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/ironic.conf Suggest to add %noreplace for above files, see earlier feedback in review. openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/dbsync.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/service.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/link.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/conductor.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/openstack/common/rpc/zmq_receiver.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/drivers/modules/deploy_utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/driver.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/state.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/chassis.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/driver_factory.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_root.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/collection.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_drivers.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/api.py 0644L /usr/bin/env Didn't see anything specific about what to do for these at https://fedoraproject.org/wiki/Packaging:Python rpmlint is complaining I assume b/c there's a shebang in the files, but they aren't actually meant to be scripts and aren't executable. Don't see anything about this at https://fedoraproject.org/wiki/Common_Rpmlint_issues The files themselves aren't +x, given the output above. What's the path forward here? It seems like the only thing that can be done in the spec itself is to make these files +x in %files. But, these things aren't actually scripts (from what I can tell), so a patch upstream to remove the #!/usr/bin/env lines from these files should probably be sumitted. Then we can add that patch to the rpm until it is merged. openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.conf ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/policy.json ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-deploy-helper.filters ironic openstack-ironic.noarch: W: non-standard-uid /var/lib/ironic ironic openstack-ironic.noarch: W: non-standard-gid /var/lib/ironic ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-images.filters ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/ironic.conf ironic These can be explained by the fact that ironic is a non standard group, so rpm doesn't know about it. I think that's ok. openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.conf 0640L openstack-ironic.noarch: E: non-readable /etc/ironic/policy.json 0640L openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-deploy-helper.filters 0640L openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-images.filters 0640L openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters 0640L openstack-ironic.noarch: E: non-readable /etc/ironic/ironic.conf 0640L These errors are b/c the files are not world readable. That is what is desired I believe. Do we need to flag them as exceptions to rpmlint somehow? openstack-ironic.noarch: W: no-manual-page-for-binary ironic-rootwrap openstack-ironic.noarch: W: no-manual-page-for-binary ironic-dbsync openstack-ironic.noarch: W: no-manual-page-for-binary ironic-conductor openstack-ironic.noarch: W: no-manual-page-for-binary ironic-api man pages don't exist for these commands. They don't for most OpenStack commands. Is that ok to ignore? openstack-ironic.src:16: W: unversioned-explicit-provides ironic This needs to be fixed. See earlier review comments. openstack-ironic.src:83: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/system/ openstack-ironic.src:84: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/ openstack-ironic.src:85: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/ openstack-ironic.src:98: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/* This needs to be fixed. See earlier review comments. openstack-ironic.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 8) This needs to be fixed. See earlier review comments. 2 packages and 0 specfiles checked; 26 errors, 22 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review