https://bugzilla.redhat.com/show_bug.cgi?id=1069335 --- Comment #6 from James Slagle <jslagle@xxxxxxxxxx> --- Hi, I'm doing an unofficial review. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel Change the BR from python-devel to python2-devel - Inconsistent alignment in spec file - Looks like you got a request for more info on the fedora ticket request for the static uid/gid - Other issues in the comments below ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files have unknown license. Detailed output of licensecheck in /home/jslagle/rpmbuild/1069335-openstack-ironic/review-openstack- ironic/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config %attr(-,root,ironic) /etc/ironic recommend to add noreplace to the above %config. We don't want local changes to these files overwritten by rpm do we? [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). Use %{_unitdir} for /usr/lib/systemd/system This requires adding BuildRequires: systemd per https://fedoraproject.org/wiki/Packaging:Systemd [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Why are there runtime requirements on the following? - swig - pyflakes These aren't in upstream ironic's requirements.txt, so they shouldn't be needed. Also need to remove the Requires on python-pbr. You'll have to provide a patch to remove the runtime requirement. See our other OpenStack packages for examples of this, (e.g. in glance there is a patch called 0002-Remove-runtime-dep-on-python-pbr.patch) [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [!]: Package complies to the Packaging Guidelines Outstanding issues mentioned elsewhere in this review. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python See other outstanding issues [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). Why is there a Provides on ironic? This shouldn't be necessary should it? Other Outstanding issues here, please see other comments [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. only tested on x86_64 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: openstack-ironic-2014.1-b2.2.fc21.noarch.rpm openstack-ironic-2014.1-b2.2.fc21.src.rpm openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.conf openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/policy.json openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-deploy-helper.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-images.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/ironic.conf openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/dbsync.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/service.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.conf ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.conf 0640L openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/link.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/conductor.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/openstack/common/rpc/zmq_receiver.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/drivers/modules/deploy_utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/driver.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/policy.json ironic openstack-ironic.noarch: E: non-readable /etc/ironic/policy.json 0640L openstack-ironic.noarch: W: non-standard-gid /etc/ironic ironic openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/state.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_utils.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-deploy-helper.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-deploy-helper.filters 0640L openstack-ironic.noarch: W: non-standard-uid /var/lib/ironic ironic openstack-ironic.noarch: W: non-standard-gid /var/lib/ironic ironic openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/chassis.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/driver_factory.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_root.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-images.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-images.filters 0640L openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters 0640L openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/collection.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_drivers.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/api.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/ironic.conf ironic openstack-ironic.noarch: E: non-readable /etc/ironic/ironic.conf 0640L openstack-ironic.noarch: W: no-manual-page-for-binary ironic-rootwrap openstack-ironic.noarch: W: no-manual-page-for-binary ironic-dbsync openstack-ironic.noarch: W: no-manual-page-for-binary ironic-conductor openstack-ironic.noarch: W: no-manual-page-for-binary ironic-api openstack-ironic.src:16: W: unversioned-explicit-provides ironic openstack-ironic.src:83: E: hardcoded-library-path in %{buildroot}/usr/lib/systemd/system/ openstack-ironic.src:84: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/ openstack-ironic.src:85: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/ openstack-ironic.src:98: E: hardcoded-library-path in %{_prefix}/lib/systemd/system/* openstack-ironic.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 18, tab: line 8) 2 packages and 0 specfiles checked; 26 errors, 22 warnings. Besides the other feedback above, the other warnings and errors look ok here. Rpmlint (installed packages) ---------------------------- # rpmlint openstack-ironic openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.conf openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/policy.json openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-deploy-helper.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-images.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters openstack-ironic.noarch: W: conffile-without-noreplace-flag /etc/ironic/ironic.conf openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/dbsync.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/service.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.conf ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.conf 0640L openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/link.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/conductor.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/openstack/common/rpc/zmq_receiver.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/drivers/modules/deploy_utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/driver.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/policy.json ironic openstack-ironic.noarch: E: non-readable /etc/ironic/policy.json 0640L openstack-ironic.noarch: W: non-standard-gid /etc/ironic ironic openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/state.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_utils.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-deploy-helper.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-deploy-helper.filters 0640L openstack-ironic.noarch: W: non-standard-uid /var/lib/ironic ironic openstack-ironic.noarch: W: non-standard-gid /var/lib/ironic ironic openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/chassis.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/common/driver_factory.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_root.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-images.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-images.filters 0640L openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d ironic openstack-ironic.noarch: W: non-standard-gid /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters ironic openstack-ironic.noarch: E: non-readable /etc/ironic/rootwrap.d/ironic-manage-ipmi.filters 0640L openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/utils.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/api/controllers/v1/collection.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/tests/api/test_drivers.py 0644L /usr/bin/env openstack-ironic.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ironic/cmd/api.py 0644L /usr/bin/env openstack-ironic.noarch: W: non-standard-gid /etc/ironic/ironic.conf ironic openstack-ironic.noarch: E: non-readable /etc/ironic/ironic.conf 0640L openstack-ironic.noarch: W: no-manual-page-for-binary ironic-rootwrap openstack-ironic.noarch: W: no-manual-page-for-binary ironic-dbsync openstack-ironic.noarch: W: no-manual-page-for-binary ironic-conductor openstack-ironic.noarch: W: no-manual-page-for-binary ironic-api 1 packages and 0 specfiles checked; 22 errors, 20 warnings. # echo 'rpmlint-done:' Requires -------- openstack-ironic (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python config(openstack-ironic) pycrypto pyflakes python(abi) python-anyjson python-eventlet python-fixtures python-glanceclient python-iso8601 python-jinja2 python-jsonpatch python-keystoneclient python-kombu python-migrate python-mock python-netaddr python-neutronclient python-paramiko python-pbr python-pecan python-sqlalchemy python-stevedore python-wsme shadow-utils swig Provides -------- openstack-ironic: config(openstack-ironic) ironic openstack-ironic Source checksums ---------------- https://launchpad.net/ironic/icehouse/icehouse-2/+download/ironic-2014.1.b2.tar.gz : CHECKSUM(SHA256) this package : b3a3bdf04df2e15519058fbe66d63b5156bcde8fc35c6cda787db3c34f2c637e CHECKSUM(SHA256) upstream package : b3a3bdf04df2e15519058fbe66d63b5156bcde8fc35c6cda787db3c34f2c637e Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -n openstack-ironic Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review