https://bugzilla.redhat.com/show_bug.cgi?id=822327 --- Comment #11 from Christopher Meng <cickumqt@xxxxxxxxx> --- Since libmediainfo hasn't arrived here, some comments: 1. No scriptlets for icon related refresh. 2. desktop-file-install --dir="%{buildroot}%{_datadir}/applications" -m 644 Why does "-m 644" appear? 3. install -m 644 -p Project/GNU/GUI/mediainfo-gui.kde4.desktop \ %{buildroot}%{_datadir}/kde4/services/ServiceMenus/mediainfo-gui.desktop You should do this by desktop-file-install or validate also. 4. Suggestion, use ImageMagick to convert pixmaps to various sizes, not only 128x128 IMO, excerpt from my spec: for size in 96x96 72x72 64x64 48x48 32x32 24x24 22x22 16x16 ; do install -pdm755 \ %{buildroot}%{_datadir}/icons/hicolor/${size}/apps convert -resize ${size} %{S:2} \ %{buildroot}%{_datadir}/icons/hicolor/${size}/apps/%{name}.png done Note that this is just an example. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review