[Bug 1069988] Review Request: naemon - Open Source Host, Service And Network Monitoring Program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069988



--- Comment #6 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #5)
> Whether successful or not, the spec file is amazingly convoluted due to
> large scriptlets and overuse of %attr.
> 
> The scriptlets apparently try to clean up the filesystem upon removal of the
> package. This will need a very careful review, because preferably you would
> use %ghost entries in %files lists to track files that get created at
> runtime and shall be deleted when removing the package.
> 
> Printing stuff in scriptlets is a "don't do that", because it isn't
> guaranteed that any package installer will display that output.
> 
> 
> Also relevant:
> 
> * https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> 
> *
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Packaging_Static_Libraries

Right.

Daniel, Please also do something:

1. Try this in terminal:

rpm -E %perl_vendorarch
rpm -E %_sharedstatedir

And correct the one you've used. Feel free to ask me about any question
related.

2. Systemd is now the primary init system, so unless you make conditional
lines,(yes for RHEL6 init is still supported) please remove sysv support.

3. You can put all you want to show to the users in a README.Fedora or
README.RHEL as %doc! And notice the file in %description.

4. # Move SystemV init-script
mv -f %{buildroot}%{_initrddir}/%{name} %{buildroot}%{_bindir}/%{name}-ctl
%endif

Why? Can't systemd start naemon well?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]