[Bug 1069616] Review Request: jenkins - An extendable open source continuous integration server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069616

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puntogil@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |puntogil@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from gil cattaneo <puntogil@xxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- This seems like a Java package, please install fedora-review-plugin-java to
  get additional checks
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "CDDL", "Unknown or generated", "MIT/X11 (BSD like)",
     "BSD (3 clause)", "LGPL (v2.1 or later)". 315 files have unknown license.
     Detailed output of licensecheck in
     /home/gil/1069616-jenkins/licensecheck.txt
FIXME
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/java/jenkins
[!]: Package contains no bundled libraries without FPC exception.
see above
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jenkins-
     core , jenkins-plugins-pom , jenkins-cli , jenkins-javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jenkins-core-1.549-1.fc21.noarch.rpm
          jenkins-plugins-pom-1.549-1.fc21.noarch.rpm
          jenkins-cli-1.549-1.fc21.noarch.rpm
          jenkins-javadoc-1.549-1.fc21.noarch.rpm
          jenkins-1.549-1.fc21.src.rpm

FIXME jenkins-core.noarch: W: class-path-in-manifest
/usr/share/java/jenkins/jenkins-core.jar

jenkins-plugins-pom.noarch: W: no-documentation
jenkins-cli.noarch: W: no-manual-page-for-binary jenkins-cli
jenkins.src: W: spelling-error %description -l en_US cron -> corn, con, crone
jenkins.src: W: spelling-error %description -l en_US procmail -> proclaim,
procaine
5 packages and 0 specfiles checked; 0 errors, 5 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint jenkins-cli jenkins-javadoc jenkins-plugins-pom jenkins-core
jenkins-cli.noarch: W: no-manual-page-for-binary jenkins-cli
jenkins-plugins-pom.noarch: W: no-documentation
FIXME jenkins-core.noarch: W: class-path-in-manifest
/usr/share/java/jenkins/jenkins-core.jar
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'



Requires
--------
jenkins-cli (rpmlib, GLIBC filtered):
    /bin/sh
    java-headless
    jpackage-utils
    mvn(commons-codec:commons-codec)
    mvn(org.codehaus.groovy:groovy18:1.8)
    mvn(org.jenkins-ci.main:remoting)
    mvn(org.jfree:jfreechart)
    mvn(org.jvnet.localizer:localizer)
    mvn(org.tmatesoft.svnkit:trilead-ssh2)

jenkins-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils

jenkins-plugins-pom (rpmlib, GLIBC filtered):
    jpackage-utils
    mvn(javax.servlet:servlet-api)
    mvn(org.apache.maven.plugins:maven-release-plugin)
    mvn(org.jenkins-ci.main:jenkins-core)
    mvn(org.jenkins-ci.tools:maven-hpi-plugin)
    mvn(org.jvnet.localizer:maven-localizer-plugin)
    mvn(org.kohsuke.stapler:maven-stapler-plugin)

jenkins-core (rpmlib, GLIBC filtered):
    java-headless
    jpackage-utils
    mvn(antlr:antlr)
    mvn(args4j:args4j)
    mvn(com.github.jnr:jnr-posix)
    mvn(com.google.code.findbugs:jsr305)
    mvn(com.google.guava:guava)
    mvn(com.google.inject:guice::no_aop:)
    mvn(com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer)
    mvn(com.infradna.tool:bridge-method-annotation)
    mvn(com.jcraft:jzlib)
    mvn(com.sun.xml.txw2:txw2)
    mvn(commons-beanutils:commons-beanutils)
    mvn(commons-codec:commons-codec)
    mvn(commons-collections:commons-collections)
    mvn(commons-digester:commons-digester)
    mvn(commons-httpclient:commons-httpclient)
    mvn(commons-io:commons-io)
    mvn(commons-jelly:commons-jelly-tags-define)
    mvn(commons-jelly:commons-jelly-tags-fmt)
    mvn(commons-jelly:commons-jelly-tags-xml)
    mvn(commons-lang:commons-lang)
    mvn(commons-logging:commons-logging)
    mvn(javax.mail:mail)
    mvn(javax.servlet:jstl)
    mvn(jaxen:jaxen)
    mvn(jline:jline)
    mvn(net.java.dev.jna:jna)
    mvn(net.java.sezpoz:sezpoz)
    mvn(org.apache.ant:ant)
    mvn(org.codehaus.groovy:groovy18:1.8)
    mvn(org.fusesource.jansi:jansi)
    mvn(org.jenkins-ci.main:cli)
    mvn(org.jenkins-ci.main:remoting)
    mvn(org.jenkins-ci:annotation-indexer)
    mvn(org.jenkins-ci:bytecode-compatibility-transformer)
    mvn(org.jenkins-ci:commons-jexl)
    mvn(org.jenkins-ci:crypto-util)
    mvn(org.jenkins-ci:jmdns)
    mvn(org.jenkins-ci:memory-monitor)
    mvn(org.jenkins-ci:task-reactor)
    mvn(org.jenkins-ci:version-number)
    mvn(org.jfree:jfreechart)
    mvn(org.jvnet.hudson:xstream)
    mvn(org.jvnet.localizer:localizer)
    mvn(org.jvnet.robust-http-client:robust-http-client)
    mvn(org.kohsuke.stapler:json-lib)
    mvn(org.kohsuke.stapler:stapler-adjunct-timeline)
    mvn(org.kohsuke.stapler:stapler-groovy)
    mvn(org.kohsuke:access-modifier-annotation)
    mvn(org.kohsuke:akuma)
    mvn(org.kohsuke:libpam4j)
    mvn(org.kohsuke:trilead-putty-extension)
    mvn(org.mindrot:jbcrypt)
    mvn(org.springframework.ldap:spring-ldap-core)
    mvn(org.springframework.ldap:spring-ldap-core-tiger)
    mvn(org.springframework.ldap:spring-ldap-ldif-batch)
    mvn(org.springframework.ldap:spring-ldap-ldif-core)
    mvn(org.springframework.ldap:spring-ldap-odm)
    mvn(org.springframework.security:spring-security-acl)
    mvn(org.springframework.security:spring-security-config)
    mvn(org.springframework.security:spring-security-core)
    mvn(org.springframework.security:spring-security-ldap)
    mvn(org.springframework.security:spring-security-web)
    mvn(org.springframework:spring-aop)
    mvn(org.springframework:spring-core)
    mvn(org.springframework:spring-webmvc)
    mvn(org.tmatesoft.svnkit:trilead-ssh2)
    mvn(xpp3:xpp3)



Provides
--------
jenkins-cli:
    jenkins-cli
    mvn(org.jenkins-ci.main:cli)

jenkins-javadoc:
    jenkins-javadoc

jenkins-plugins-pom:
    jenkins-plugins-pom
    mvn(org.jenkins-ci.plugins:plugin)
    mvn(org.jenkins-ci.plugins:plugin:pom:)

jenkins-core:
    jenkins-core
    mvn(org.jenkins-ci.main:jenkins-core)
    mvn(org.jenkins-ci.main:pom)
    mvn(org.jenkins-ci.main:pom:pom:)



Source checksums
----------------
https://github.com/jenkinsci/jenkins/archive/jenkins-1.549.tar.gz :
  CHECKSUM(SHA256) this package     :
861266b3e587714242bb4648452b5429a52dda3737dac47bb0531d11c397602f
  CHECKSUM(SHA256) upstream package :
861266b3e587714242bb4648452b5429a52dda3737dac47bb0531d11c397602f


Jar and class files in source
-----------------------------
./jenkins-jenkins-1.549/test/src/test/resources/hudson/util/ProcessTreeKiller-test-project.jar


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1069616 -m fedora-rawhide-i386 -L
local-dependencies
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Built with local dependencies:
   
/home/gil/local-dependencies/jenkins-xstream-1.4.4-1.jenkins5.fc21.noarch.rpm
    /home/gil/local-dependencies/jenkins-jexl-1.1-1.20111212.fc21.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]