https://bugzilla.redhat.com/show_bug.cgi?id=1069882 --- Comment #3 from Steven Dake <sdake@xxxxxxxxxx> --- Couple notes: 1) Recommend changing the source URL to the openstack tarball location: http://tarballs.openstack.org/python-ironicclient/python-ironicclient-0.1.2.tar.gz 2) I would recommend adding a build requires for python-setuptools I would recommend removing: rm -rf python_ironicclient.egg-info 2.a) I believe the egg-info is needed # Let RPM handle deps sed -i '/setup_requires/d; /install_requires/d; /dependency_links/d' setup.py 2.b) hacking setup.py via sed is evil and prone to breakage # Remove the requirements file so that pbr hooks don't add it # to distutils requires_dist config rm -rf {test-,}requirements.txt 2.c) removing upstream files to hack around pbr dependencies not wanted in the runtime can be fixed in other ways And instead handle that with patches. Take a look at how other python clients are done for OpenStack. Its pretty straight forward. (fedpkg clone python-novaclient for example) 3) You don't need to remove the buildroot rm -rf %{buildroot}%{python2_sitelib}/python_ironicclient* Otherwise looks pretty good. After these issues are fixed up, I'll provide a complete review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review