https://bugzilla.redhat.com/show_bug.cgi?id=1064576 Cole Robinson <crobinso@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |crobinso@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |crobinso@xxxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Cole Robinson <crobinso@xxxxxxxxxx> --- fedora-review doesn't flag anything interesting, nothing major from manual review. minor bits: - %{modname} can be used in Name: as well - I've seen people use %{name} for Patch lines as well - https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools : suggests simply doing %{python2_sitelib}/* in %files to catch the module and egg-info directory - The package description doesn't explicitly distinguish python2/python3 besides including the package name. But those are all minor points that I'll leave to your discretion. setting fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review