https://bugzilla.redhat.com/show_bug.cgi?id=1067098 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- The patches are Ok. FIX: Build-require perl(Data::Dumper) (t/state.t:175). Notice: perl(Encode) is optional (t/unicode.t:25). Ok. FIX: Build-require perl(File::Path) (t/spool.t:72). Notice: perl(File::Temp) is optional (t/unicode.t:21). Ok. TODO: Build-require perl(overload) (t/lib/Test/Builder.pm:466). TODO: Build-require perl(Symbol) (t/spool.t:29). FIX: Build-require perl(TAP::Formatter::Base) (t/file.t:28). Notice: perl(TAP::Formatter::HTML) is optional (t/proveversion.t:8). Ok. Notice: perl(TAP::Harness::Archive) is optional (t/compat/env_opts.t:11). Ok. TODO: Remove modules bundled in t/lib like like Test::More, Test::Builder. Notice: perl(threads::shared) is not used (t/lib/Test/Builder.pm:21). Ok. Notice: perl(YAML) is optional (t/prove.t:81). Ok. All tests pass. Ok. $ rpmlint perl-TAP-Harness-Env.spec ../SRPMS/perl-TAP-Harness-Env-3.30-2.fc20.src.rpm ../RPMS/noarch/perl-TAP-Harness-Env-3.30-2.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-2.fc20.noarch.rpm drwxr-xr-x 2 root root 0 úno 26 17:27 /usr/share/doc/perl-TAP-Harness-Env -rw-r--r-- 1 root root 41022 lis 12 23:58 /usr/share/doc/perl-TAP-Harness-Env/Changes -rw-r--r-- 1 root root 541 lis 12 23:58 /usr/share/doc/perl-TAP-Harness-Env/README -rw-r--r-- 1 root root 2102 úno 26 17:27 /usr/share/man/man3/TAP::Harness::Env.3pm.gz -rw-r--r-- 1 root root 3824 lis 12 23:58 /usr/share/perl5/vendor_perl/TAP/Harness/Env.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-2.fc20.noarch.rpm | sort | uniq -c 1 perl(constant) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(strict) 1 perl(TAP::Object) 1 perl(Text::ParseWords) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-2.fc20.noarch.rpm | sort | uniq -c 1 perl(TAP::Harness::Env) = 3.30 1 perl-TAP-Harness-Env = 3.30-2.fc20 Binary provides are Ok. $ resolvedeps f20-build ../RPMS/noarch/perl-TAP-Harness-Env-3.30-2.fc20.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6573547). Ok. Please correct all `FIX' items and consider fixing `TODO' items before building the package. Resolution: Package APPROVED. I will add the Obsoletes into F21's perl-Test-Harness tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review