https://bugzilla.redhat.com/show_bug.cgi?id=1067098 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: ff1900f3b3e61321d3c4b3283298f3106d43d55446605e9cfcf1dcec036acec1). Ok. TODO: I'd like rather see removing the files from ./script, ./lib, maybe some tests, and MANIFEST in %prep section instead of %exclude-ing them in %files section. This would assure the tests are run against system modules. Such building and testing would have higher integration value. It would also simplify this review and listing all build-time dependencies. TODO: %exclude %{_mandir}/man3/Test::* instead of each manual page to be consistent with excluding %{perl_vendorlib}/Test/. Summary verified from lib/TAP/Harness/Env.pm. Ok. Description verified from lib/TAP/Harness/Env.pm. Ok. License verified from README and vairous ./lib files. Ok. Old spec cruft kept for EPEL. Ok. No XS code, noarch BuildArch is Ok. TODO: Build-require perl(strict) (Makefile.PL:10). TOOD: Build-require perl(warnings) (Makefile.PL:11). FIX: There are various build-time dependencies missing. E.g. perl(Carp), perl(File::Spec), etc. Many of them live in standalone package in F21. See perl-Test-Harness.spec in F21. All tests pass. Ok. $ rpmlint perl-TAP-Harness-Env.spec ../SRPMS/perl-TAP-Harness-Env-3.30-1.fc20.src.rpm ../RPMS/noarch/perl-TAP-Harness-Env-3.30-1.fc20.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-1.fc20.noarch.rpm drwxr-xr-x 2 root root 0 úno 26 10:36 /usr/share/doc/perl-TAP-Harness-Env -rw-r--r-- 1 root root 41022 lis 12 23:58 /usr/share/doc/perl-TAP-Harness-Env/Changes -rw-r--r-- 1 root root 541 lis 12 23:58 /usr/share/doc/perl-TAP-Harness-Env/README -rw-r--r-- 1 root root 2102 úno 26 10:35 /usr/share/man/man3/TAP::Harness::Env.3pm.gz -rw-r--r-- 1 root root 3824 lis 12 23:58 /usr/share/perl5/vendor_perl/TAP/Harness/Env.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-1.fc20.noarch.rpm | sort | uniq -c 1 perl(constant) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(strict) 1 perl(TAP::Object) 1 perl(Text::ParseWords) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-TAP-Harness-Env-3.30-1.fc20.noarch.rpm | sort | uniq -c 1 perl(TAP::Harness::Env) = 3.30 1 perl-TAP-Harness-Env = 3.30-1.fc20 Binary provides are Ok. $ resolvedeps f20-build ../RPMS/noarch/perl-TAP-Harness-Env-3.30-1.fc20.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F20 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6572235). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review