https://bugzilla.redhat.com/show_bug.cgi?id=1064995 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok. Source archive is original (SHA-256: ded61a7ab96db8c6a14466a5984091a60af9b384b3355d06aeaa6433ac977c02). Ok. File-Slurp-Tiny-0.003-old-Test::More.patch is Ok. Summary verified from lib/File/Slurp/Tiny.pm. Ok. Description verified from lib/File/Slurp/Tiny.pm. Ok. TODO: Although the package name indicates what is slurped and spewed, I'd like to see explicit mention in the description that it's about files (content). License verified from README, LICENSE, lib/File/Slurp/Tiny.pm. Ok. No XS code, noarch BuildArch is Ok. Old spec cruft presents for EPEL. Ok. TODO: Specify versions at Test::Pod* build-requires. (Versions are missing to allow gracious degradation of tests probably.) Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-File-Slurp-Tiny.spec ../SRPMS/perl-File-Slurp-Tiny-0.003-2.fc21.src.rpm ../RPMS/noarch/perl-File-Slurp-Tiny-0.003-2.fc21.noarch.rpm perl-File-Slurp-Tiny.src: W: spelling-error Summary(en_US) slurper -> slurped, slur per, slur-per perl-File-Slurp-Tiny.noarch: W: spelling-error Summary(en_US) slurper -> slurped, slur per, slur-per 2 packages and 1 specfiles checked; 0 errors, 2 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-File-Slurp-Tiny-0.003-2.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Feb 26 09:18 /usr/share/doc/perl-File-Slurp-Tiny -rw-r--r-- 1 root root 392 Jan 21 00:03 /usr/share/doc/perl-File-Slurp-Tiny/Changes -rw-r--r-- 1 root root 18356 Jan 21 00:03 /usr/share/doc/perl-File-Slurp-Tiny/LICENSE -rw-r--r-- 1 root root 384 Jan 21 00:03 /usr/share/doc/perl-File-Slurp-Tiny/README -rw-r--r-- 1 root root 2704 Feb 26 09:18 /usr/share/man/man3/File::Slurp::Tiny.3pm.gz drwxr-xr-x 2 root root 0 Feb 26 09:18 /usr/share/perl5/vendor_perl/File drwxr-xr-x 2 root root 0 Feb 26 09:18 /usr/share/perl5/vendor_perl/File/Slurp -rw-r--r-- 1 root root 4332 Jan 21 00:03 /usr/share/perl5/vendor_perl/File/Slurp/Tiny.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-File-Slurp-Tiny-0.003-2.fc21.noarch.rpm | sort | uniq -c 1 perl(Carp) 1 perl(Exporter) >= 5.57 1 perl(FileHandle) 1 perl(File::Spec::Functions) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-File-Slurp-Tiny-0.003-2.fc21.noarch.rpm | sort | uniq -c 1 perl(File::Slurp::Tiny) = 0.003 1 perl-File-Slurp-Tiny = 0.003-2.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-File-Slurp-Tiny-0.003-2.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6571978). Ok. Package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review