[Bug 1069124] Review Request: python-netlib - Collection of network utility classes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1069124

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Package build successfully in rawhide mock

+ Source verified with upstream as (sha256sum)
srpm tarball : 415e3db96f487177f372d47bc669dcc9068a435e49b8120ec8821026de36bd80
upstream tarball :
415e3db96f487177f372d47bc669dcc9068a435e49b8120ec8821026de36bd80

+ rpmlint on generated rpms gave output
python-netlib.noarch: W: spelling-error %description -l en_US pathod -> pathos,
pat hod, pat-hod
python-netlib.noarch: W: spelling-error %description -l en_US mitmproxy ->
proximity
python-netlib.noarch: W: spelling-error %description -l en_US misbehaviour ->
misbehavior, behaviorism
python-netlib.src: W: spelling-error %description -l en_US pathod -> pathos,
pat hod, pat-hod
python-netlib.src: W: spelling-error %description -l en_US mitmproxy ->
proximity
python-netlib.src: W: spelling-error %description -l en_US misbehaviour ->
misbehavior, behaviorism
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ License of this package is MIT which is given in source setup.py.


Suggestions:
1) Group tag is optional so you can remove it if this package is only for
Fedora.

2) Package should own %{python2_sitelib}/* files only and not directory
%{python2_sitelib}

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]