Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: SDL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226402 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|RAWHIDE | ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-04-03 09:47 EST ------- Thomas, Thanks for fixing most open SDL bugs and for fixing/answering most of my questions. As stated however, my initial list of questions wasn't a full review yet, so bug isn't resolved yet, reopening. And then now the full review: MUST: ===== 0 rpmlint output is: W: SDL-devel summary-ended-with-dot Files needed to develop Simple DirectMedia Layer applications. W: SDL rpm-buildroot-usage %prep rm -rf %{buildroot} W: SDL macro-in-%changelog build * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * ldconfig run for shared libraries * Not relocatable 0 Package owns / or requires all dirs * No duplicate files & Permissions * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * -devel package as needed * no .desktop file required Should Fix ========== * remove this line: "CFLAGS="$RPM_OPT_FLAGS" CXXFLAGS="$RPM_OPT_FLAGS" \", this is Superfluous, as %configure already does this itself * remove "README-SDL.txt COPYING CREDITS BUGS" from %files devel's %doc, they are already included in the main %doc, which is required by -devel * bug 234823 bug 208212 Must Fix ======== * From rpmlint: * Drop the . at the end of the -devel package summary * Drop "rm -rf %{buildroot}" from %prep (already done at the begin of %install) * change %build in %changelog to %%build * Drop the static library from -devel * Add "Requires: pkgcconfig" to -devel subpackage for proper ownership of the /usr/%{_lib}/pkgconfig directory * Add "Requires: automake" to -devel subpackage for proper ownership of the /usr/share/aclocal directory As said before all in all a pretty good package! and once the above fixes have been applied its "perfect" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review