https://bugzilla.redhat.com/show_bug.cgi?id=1060386 --- Comment #13 from Michael Schwendt <bugs.michael@xxxxxxx> --- Running "fedora-review -b 1060386" fails. Please keep the "Spec URL:" and "SRPM URL:" lines up-to-date. [...] Which rpmlint warnings/error do you find frustrating? Try "rpmlint -i …" on the built rpm. The -i adds helpful output. If you get too many W/E, you can also query rpmlint for its help, e.g. $ rpmlint -I service-default-enabled service-default-enabled: The service is enabled by default after "chkconfig --add"; for security reasons, most services should not be. Use "-" as the default runlevel in the init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword to fix this if appropriate for this service. $ rpmlint -I conffile-without-noreplace-flag conffile-without-noreplace-flag: A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here [...] > pandorafms-agent.noarch: W: dangerous-command-in-%preun userdel https://fedoraproject.org/wiki/Packaging:UsersAndGroups > %post > mkdir -p /var/spool/pandora/data_out Why aren't these directories included in the package? > %doc An empty %doc does nothing. > /usr/share/man/man1/pandora_agent.1.gz > /usr/share/man/man1/tentacle_client.1.gz $ rpm -E %_mandir /usr/share/man Typically, one uses wildcards and macros to include the files: %{_mandir}/man1/*.1* Not specifying the trailing .gz is not a big issue, but allows for disabling/changing/customizing compressing of manual pages without breaking the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review