https://bugzilla.redhat.com/show_bug.cgi?id=1066559 František Dvořák <valtri@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from František Dvořák <valtri@xxxxxxxxxx> --- I'm sorry, I swapped the arguments for touch ('-r' is for the reference file): iconv -f ISO-8859-1 -t UTF8 ChangeLog > tmp && \ touch -r ChangeLog tmp && \ mv tmp ChangeLog Also the dll library has atypical name: libid3-3-8-3.dll. It is possible to change it by removing "-release $(LT_RELEASE)" from libid3_la_LDFLAGS (in the mingw patch), then name would be libid3-3.dll. I'm not sure if it is important, it is probably mere cosmetics... Fixing touch (and changing result dll name if to do it) can be done post review. Package APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review