https://bugzilla.redhat.com/show_bug.cgi?id=1066559 --- Comment #5 from František Dvořák <valtri@xxxxxxxxxx> --- Nice! The autoreconf way is better. :-) It could be opened low priority bug against id3lib Fedora package (there is already another packaging bug waiting there). The proper way would be to send the patch to upstream, but it doesn't seem very active now... About the 5: the recommended way is to use formatting from rpmdevtools examples: https://git.fedorahosted.org/cgit/rpmdevtools.git/plain/spectemplate-lib.spec , but the current formatting is OK. Full review report bellow. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - I think the seds for libtool are not needed now? - fedora-review complains about obsolete autoconf macros, can you also replace AM_PROG_LIBTOOL by LT_INIT? Similar changes as in ./configure.in can be done in zlib/configure.in - converting files changes the timestamps, there is a trick how to keep timestamp in some other packages: iconv -f ISO-8859-1 -t UTF8 ChangeLog > tmp && \ touch -r tmp ChangeLog && \ mv tmp ChangeLog ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* LGPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or generated", "zlib/libpng". 29 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 901120 bytes in 16 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. See above. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools See above. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-id3lib-3.8.3-31.fc21.noarch.rpm mingw32-id3lib-tools-3.8.3-31.fc21.noarch.rpm mingw64-id3lib-3.8.3-31.fc21.noarch.rpm mingw64-id3lib-tools-3.8.3-31.fc21.noarch.rpm mingw-id3lib-3.8.3-31.fc21.src.rpm mingw32-id3lib.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw32-id3lib.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw32-id3lib.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/writers.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/utils.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/writer.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/sized_types.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-id3lib/COPYING mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/globals.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_streams.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_strings.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_frame.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/misc_support.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/field.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/tag.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/reader.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/readers.h mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw32-id3lib-tools.noarch: W: no-documentation mingw64-id3lib.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw64-id3lib.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw64-id3lib.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_frame.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/reader.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/writer.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/field.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/sized_types.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_strings.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/misc_support.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/readers.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/writers.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/tag.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/utils.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-id3lib/COPYING mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/globals.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_streams.h mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw64-id3lib-tools.noarch: W: no-documentation mingw-id3lib.src: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw-id3lib.src: W: spelling-error %description -l en_US de -> DE, ed, d mingw-id3lib.src: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate 5 packages and 0 specfiles checked; 30 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw64-id3lib mingw64-id3lib-tools mingw32-id3lib-tool s mingw32-id3lib mingw64-id3lib.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw64-id3lib.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw64-id3lib.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_frame.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/reader.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/writer.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/field.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/sized_types.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_strings.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/misc_support.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/readers.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/writers.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/tag.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/utils.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-id3lib/COPYING mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/globals.h mingw64-id3lib.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/id3/id3lib_streams.h mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw64-id3lib-tools.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw64-id3lib-tools.noarch: W: no-documentation mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw32-id3lib-tools.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw32-id3lib-tools.noarch: W: no-documentation mingw32-id3lib.noarch: W: spelling-error %description -l en_US synchronisation -> synchronization, synchronicity mingw32-id3lib.noarch: W: spelling-error %description -l en_US de -> DE, ed, d mingw32-id3lib.noarch: W: spelling-error %description -l en_US bitrate -> nitrate, bit rate, bit-rate mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/writers.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/utils.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/writer.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/sized_types.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-id3lib/COPYING mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/globals.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_streams.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_strings.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/id3lib_frame.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/misc_support.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/field.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/tag.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/reader.h mingw32-id3lib.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/id3/readers.h 4 packages and 0 specfiles checked; 30 errors, 14 warnings. # echo 'rpmlint-done:' Requires -------- mingw64-id3lib (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(zlib1.dll) mingw64-crt mingw64-filesystem mingw64-id3lib-tools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgcc_s_seh-1.dll) mingw64(libid3-3-8-3.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-id3lib mingw32-id3lib-tools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libid3-3-8-3.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw32-id3lib mingw32-id3lib (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(zlib1.dll) mingw32-crt mingw32-filesystem Provides -------- mingw64-id3lib: mingw64(libid3-3-8-3.dll) mingw64-id3lib mingw64-id3lib-tools: mingw64-id3lib-tools mingw32-id3lib-tools: mingw32-id3lib-tools mingw32-id3lib: mingw32(libid3-3-8-3.dll) mingw32-id3lib Source checksums ---------------- http://downloads.sourceforge.net/id3lib/id3lib-3.8.3.tar.gz : CHECKSUM(SHA256) this package : 2749cc3c0cd7280b299518b1ddf5a5bcfe2d1100614519b68702230e26c7d079 CHECKSUM(SHA256) upstream package : 2749cc3c0cd7280b299518b1ddf5a5bcfe2d1100614519b68702230e26c7d079 AutoTools: Obsoleted m4s found ------------------------------ AM_PROG_LIBTOOL found in: id3lib-3.8.3/configure.in:95 AC_PROG_LIBTOOL found in: id3lib-3.8.3/zlib/configure.in:26 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1066559 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review