https://bugzilla.redhat.com/show_bug.cgi?id=1065641 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #3 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. SPEC first line is empty, please remove if you don't have any reason. 2. Name: libhttpserver ..... [cut] ..... BuildRequires: libmicrohttpd >= 0.9.7 BuildRequires: autoconf, automake, libtool Requires: libmicrohttpd >= 0.9.7 -----> Here come the issues: i. BuildRequires: libmicrohttpd >= 0.9.7 Please BuildRequires: libmicrohttpd-devel ii. Please remove explicit requires as RPM dep resolver will add it automatically: Requires: libmicrohttpd >= 0.9.7 iii. You can remove that version constraint as even EPEL5 ships 0.9.22 at least. 3. %package devel Summary: Development files for %{name} BuildRequires: libmicrohttpd >= 0.9.7 BuildRequires: libmicrohttpd-devel >= 0.9.7 Group: Development/Libraries Requires: libmicrohttpd >= 0.9.7 Requires: libmicrohttpd-devel >= 0.9.7 Requires: %{name}%{?_isa} = %{version}-%{release} Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig -----> Here come the issues: i. BuildRequires: libmicrohttpd >= 0.9.7 BuildRequires: libmicrohttpd-devel >= 0.9.7 You've already done that in main package(see the #2 issue set I pointed out), please remove duplicated fields. ii. Requires: libmicrohttpd-devel >= 0.9.7 devel package should requires devel packages also, and should be: Requires: libmicrohttpd-devel%{?_isa} iii. Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig Drop them. 4. autoreconf -i -s Please move above to %build section, and use: autoreconf -fiv to show verbose outputs. 5. mkdir build cd build ../configure --prefix=/usr --libdir=%{_libdir} make i. Please use %configure macro. ii. Why don't you configure directly but cd in build/? iii. Parallel make support: https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make 6. Drop this in %install forever: rm -rf $RPM_BUILD_ROOT 7. find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' find $RPM_BUILD_ROOT -name '*.*a' -delete -print 8. Drop %clean section forever. 9. Drop %defattr(-,root,root) forever. 10. Back to #7, what I want to tell you is that please don't ship static library: %{_libdir}/*.a <--- Remove this line in %files. Quoted from https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries: "In general, packagers are strongly encouraged not to ship static libs unless a compelling reason exists." -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review