[Bug 1060386] Review Request: pandorafms-agent - Pandora FMS Linux agent.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1060386



--- Comment #11 from Christopher Meng <cickumqt@xxxxxxxxx> ---
OK.

Second stage(dont be panic, a lot still):

0. Why don't you use tarball at here: 

http://sourceforge.net/projects/pandora/files/Pandora%20FMS%205.0/FinalSP3/Tarball/pandorafms_agent_unix-5.0SP3.tar.gz

as source?

1. Vendor: Artica <http://www.artica.es>

Remove this.

2. Please remove the lines, don't comment them.

3. No need to add these IMO: Requires(pre): /bin/sed /bin/grep 

4. Requires(preun): initscripts, chkconfig
Requires(post): initscripts, chkconfig
Requires(postun): initscripts

I'm sorry, please learn systemd, and write a service file:

https://fedoraproject.org/wiki/Packaging:Systemd

4. rm -rf %{buildroot} in %install section is not needed, delete it.

5. Please perserve the timestamp with install -p option:

6. %description is too poor, you are the upstream right? Why not improve it?

7. You didn't read comment 7 carefully, please remove %clean section.

8. changelog release field syntax incorrect.

Please rpmdev-bumpspec to bump the spec and see what will happen, then fix it.

9. Please learn and replace macros: 

https://fedoraproject.org/wiki/Packaging:RPMMacros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]