https://bugzilla.redhat.com/show_bug.cgi?id=1010557 --- Comment #21 from Kevin Fenzi <kevin@xxxxxxxxx> --- So, a few comments before a formal review: (In reply to Satyajit Sahoo from comment #17) > (In reply to Mukundan Ragavan from comment #16) > > This is an unofficial review. Hopefully, you will find a sponsor soon who > > can do a formal review. > > > > One question I have about the spec file is - > > > > * If they are separate packages without depending on each other in this > > case, why is there a requires? > > > > Requires: numix-openbox-theme > > Requires: numix-xfwm4-theme > > > > Shouldn't all these packages only require numix-common since that is package > > containing common files for the theme? > > When a user installs the numix-themes package, he expects to have all the > themes installed. A GTK3 theme is incomplete without a matching GTK2 theme, > a GTK theme in incomplete without a matching WM theme (metacity, xfwm or > openbox) etc. Hence the "Requires". There is no numix-themes package. ;) You aren't defining files for it, so it doesn't get produced by rpm. So, your Requires are all not used. ;( Since the common one has the license files and docs, the others really should require it. So, perhaps drop numix-common and just put that in a base numix-themes package? Are you planning on submitting any other packages? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review