[Bug 968607] Review Request: nodeunit - Easy asynchronous unit testing framework for Node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=968607



--- Comment #6 from Tom Hughes <tom@xxxxxxxxxx> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
[!]: Package contains no bundled libraries without FPC exception.

lib/assert.js is still included in built package - it needs to
be removed in %prep

[!]: Latest version is packaged.

0.8.6 is the current release


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 10 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nodeunit-0.8.1-3.fc21.noarch.rpm
          nodeunit-0.8.1-3.fc21.src.rpm
nodeunit.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodeunit.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodeunit.noarch: W: spelling-error %description -l en_US setUp -> set Up,
setup, setups
nodeunit.noarch: W: spelling-error %description -l en_US tearDown -> tear Down,
tear-down, downhearted
nodeunit.noarch: W: spelling-error %description -l en_US jUnit -> j Unit, unit,
jun it
nodeunit.noarch: W: invalid-url URL: https://github.com/caolan/nodeunit
<urlopen error timed out>
nodeunit.noarch: W: only-non-binary-in-usr-lib
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/ejs /usr/lib/node_modules/ejs
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/tap /usr/lib/node_modules/tap
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/async /usr/lib/node_modules/async
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/console.log
/usr/lib/node_modules/console.log
nodeunit.noarch: W: dangling-symlink /usr/bin/nodeunit
/usr/lib/node_modules/nodeunit/bin/nodeunit
nodeunit.src: W: spelling-error Summary(en_US) js -> dis, ks, j
nodeunit.src: W: spelling-error %description -l en_US js -> dis, ks, j
nodeunit.src: W: spelling-error %description -l en_US setUp -> set Up, setup,
setups
nodeunit.src: W: spelling-error %description -l en_US tearDown -> tear Down,
tear-down, downhearted
nodeunit.src: W: spelling-error %description -l en_US jUnit -> j Unit, unit,
jun it
nodeunit.src: W: invalid-url URL: https://github.com/caolan/nodeunit <urlopen
error _ssl.c:489: The handshake operation timed out>
2 packages and 0 specfiles checked; 0 errors, 18 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint nodeunit
nodeunit.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j
nodeunit.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodeunit.noarch: W: spelling-error %description -l en_US setUp -> set Up,
setup, setups
nodeunit.noarch: W: spelling-error %description -l en_US tearDown -> tear Down,
tear-down, downhearted
nodeunit.noarch: W: spelling-error %description -l en_US jUnit -> j Unit, unit,
jun it
nodeunit.noarch: W: invalid-url URL: https://github.com/caolan/nodeunit
<urlopen error timed out>
nodeunit.noarch: W: only-non-binary-in-usr-lib
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/ejs /usr/lib/node_modules/ejs
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/tap /usr/lib/node_modules/tap
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/async /usr/lib/node_modules/async
nodeunit.noarch: W: dangling-symlink
/usr/lib/node_modules/nodeunit/node_modules/console.log
/usr/lib/node_modules/console.log
nodeunit.noarch: W: dangling-symlink /usr/bin/nodeunit
/usr/lib/node_modules/nodeunit/bin/nodeunit
1 packages and 0 specfiles checked; 0 errors, 12 warnings.
# echo 'rpmlint-done:'



Requires
--------
nodeunit (rpmlib, GLIBC filtered):
    nodejs(engine)
    npm(async)
    npm(console.log)
    npm(ejs)
    npm(tap)



Provides
--------
nodeunit:
    nodeunit
    npm(nodeunit)



Source checksums
----------------
http://registry.npmjs.org/nodeunit/-/nodeunit-0.8.1.tgz :
  CHECKSUM(SHA256) this package     :
a4dc1b7ca6ac8e5f17aa794ad751f3eb0be40816260072f6da39447c3ee1946b
  CHECKSUM(SHA256) upstream package :
a4dc1b7ca6ac8e5f17aa794ad751f3eb0be40816260072f6da39447c3ee1946b


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 968607
Buildroot used: compton-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]