https://bugzilla.redhat.com/show_bug.cgi?id=1068937 Tom Hughes <tom@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Tom Hughes <tom@xxxxxxxxxx> --- I think the only thing I would question is the decision to install into %{_jsdir}/js-json and I would suggest considering %{_jsdir}/json instead, with the js- prefix from the package name dropped. The javascript guidelines don't require this, but the example used there (jquery) uses a directory without the js- prefix, and the few already packaged examples like js-underscore have dropped it from the directory. That's not a blocker though, so package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review