https://bugzilla.redhat.com/show_bug.cgi?id=1020942 --- Comment #39 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Possible issues: 1. The note about large documentation. The docs are already a subpackage but perhaps the docs for wxBase3 are fairly large? 2. There are a lot of mixed licenses in here, all FOSS, but how should they be attributed? 3. Directories which are owned by other packages (i.e. wxGTK-devel, see below). I don't think this is a problem but would like to hear other opions. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel * The only python file is related to a bakefile, I don't think we need to BR python-devel. - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 161495040 bytes in 5307 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Public domain", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated", "BSD (4 clause)", "MIT/X11 (BSD like)", "LGPL (v2 or later) (with incorrect FSF address)", "*No copyright* Public domain", "BSD (3 clause)", "BSD", "GPL (v2 or later) (with incorrect FSF address)", "libpng", "zlib/libpng". 4360 files have unknown license. Detailed output of licensecheck in /home/build /fedora-review/1020942-wxGTK3/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/bakefile, /usr/share/bakefile/presets * These are owned by the bakefile package, not sure if the bakefile package should be pulled in or not. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/wx/config(wxGTK- devel), /usr/lib64/wx(wxGTK-devel), /usr/lib64/wx/include(wxGTK-devel) * I don't think wxGTK and wxGTK3 co-owning these is a problem. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [-]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in wxBase3 * This sub-package can probably be installed by itself, though I'm not sure if that's useful or not. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3246080 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wxGTK3-3.0.0-4.fc19.x86_64.rpm wxGTK3-devel-3.0.0-4.fc19.x86_64.rpm wxGTK3-gl-3.0.0-4.fc19.x86_64.rpm wxGTK3-media-3.0.0-4.fc19.x86_64.rpm wxBase3-3.0.0-4.fc19.x86_64.rpm wxGTK3-docs-3.0.0-4.fc19.noarch.rpm wxGTK3-3.0.0-4.fc19.src.rpm wxGTK3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK3-3.0.0/lgpl.txt wxGTK3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK3-3.0.0/gpl.txt wxGTK3-devel.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-devel.x86_64: W: no-documentation wxGTK3-devel.x86_64: W: no-manual-page-for-binary wxrc-3.0 wxGTK3-devel.x86_64: W: no-manual-page-for-binary wx-config-3.0 wxGTK3-gl.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxGTK3-gl.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-gl.x86_64: W: no-documentation wxGTK3-media.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxGTK3-media.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-media.x86_64: W: no-documentation wxBase3.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxBase3.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxBase3.x86_64: W: spelling-error %description -l en_US wxString -> stringing, string wxBase3.x86_64: W: spelling-error %description -l en_US wxBase -> abase wxBase3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase3-3.0.0/lgpl.txt wxBase3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase3-3.0.0/gpl.txt wxGTK3-docs.noarch: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3.src: W: spelling-error Summary(en_US) wxWidgets -> widgets wxGTK3.src: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 24) 7 packages and 0 specfiles checked; 4 errors, 18 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint wxGTK3 wxGTK3-media wxGTK3-gl wxBase3 wxGTK3-devel wxGT K3-docs wxGTK3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK3-3.0.0/lgpl.txt wxGTK3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxGTK3-3.0.0/gpl.txt wxGTK3-media.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxGTK3-media.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-media.x86_64: W: no-documentation wxGTK3-gl.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxGTK3-gl.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-gl.x86_64: W: no-documentation wxBase3.x86_64: W: spelling-error Summary(en_US) wxWidgets -> widgets wxBase3.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxBase3.x86_64: W: spelling-error %description -l en_US wxString -> stringing, string wxBase3.x86_64: W: spelling-error %description -l en_US wxBase -> abase wxBase3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase3-3.0.0/lgpl.txt wxBase3.x86_64: E: incorrect-fsf-address /usr/share/doc/wxBase3-3.0.0/gpl.txt wxGTK3-devel.x86_64: W: spelling-error %description -l en_US wxWidgets -> widgets wxGTK3-devel.x86_64: W: no-documentation wxGTK3-devel.x86_64: W: no-manual-page-for-binary wxrc-3.0 wxGTK3-devel.x86_64: W: no-manual-page-for-binary wx-config-3.0 wxGTK3-docs.noarch: W: spelling-error %description -l en_US wxWidgets -> widgets 6 packages and 0 specfiles checked; 4 errors, 15 warnings. # echo 'rpmlint-done:' Requires -------- wxGTK3 (rpmlib, GLIBC filtered): /sbin/ldconfig libSDL-1.2.so.0()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libXxf86vm.so.1()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libmspack.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpng15.so.15()(64bit) libpng15.so.15(PNG15_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) libwebkitgtk-3.0.so.0()(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_baseu_xml-3.0.so.0()(64bit) libwx_baseu_xml-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_html-3.0.so.0()(64bit) libwx_gtk3u_html-3.0.so.0(WXU_3.0)(64bit) rtld(GNU_HASH) wxBase3(x86-64) wxGTK3-media (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstinterfaces-0.10.so.0()(64bit) libgstreamer-0.10.so.0()(64bit) libgtk-3.so.0()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) rtld(GNU_HASH) wxGTK3(x86-64) wxGTK3-gl (rpmlib, GLIBC filtered): /sbin/ldconfig libGL.so.1()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgdk-3.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) rtld(GNU_HASH) wxGTK3(x86-64) wxBase3 (rpmlib, GLIBC filtered): /sbin/ldconfig ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) wxGTK3-devel (rpmlib, GLIBC filtered): /bin/sh gtk3-devel libGLU-devel libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_baseu_net-3.0.so.0()(64bit) libwx_baseu_xml-3.0.so.0()(64bit) libwx_baseu_xml-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_aui-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_gl-3.0.so.0()(64bit) libwx_gtk3u_html-3.0.so.0()(64bit) libwx_gtk3u_media-3.0.so.0()(64bit) libwx_gtk3u_propgrid-3.0.so.0()(64bit) libwx_gtk3u_qa-3.0.so.0()(64bit) libwx_gtk3u_ribbon-3.0.so.0()(64bit) libwx_gtk3u_richtext-3.0.so.0()(64bit) libwx_gtk3u_stc-3.0.so.0()(64bit) libwx_gtk3u_webview-3.0.so.0()(64bit) libwx_gtk3u_xrc-3.0.so.0()(64bit) rtld(GNU_HASH) wxBase3 wxGTK3(x86-64) wxGTK3-gl wxGTK3-media wxGTK3-docs (rpmlib, GLIBC filtered): wxGTK3(x86-64) Provides -------- wxGTK3: libwx_gtk3u_adv-3.0.so.0()(64bit) libwx_gtk3u_adv-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_aui-3.0.so.0()(64bit) libwx_gtk3u_aui-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_core-3.0.so.0()(64bit) libwx_gtk3u_core-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_html-3.0.so.0()(64bit) libwx_gtk3u_html-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_propgrid-3.0.so.0()(64bit) libwx_gtk3u_propgrid-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_qa-3.0.so.0()(64bit) libwx_gtk3u_qa-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_ribbon-3.0.so.0()(64bit) libwx_gtk3u_ribbon-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_richtext-3.0.so.0()(64bit) libwx_gtk3u_richtext-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_stc-3.0.so.0()(64bit) libwx_gtk3u_stc-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_webview-3.0.so.0()(64bit) libwx_gtk3u_webview-3.0.so.0(WXU_3.0)(64bit) libwx_gtk3u_xrc-3.0.so.0()(64bit) libwx_gtk3u_xrc-3.0.so.0(WXU_3.0)(64bit) wxGTK3 wxGTK3(x86-64) wxWidgets wxGTK3-media: libwx_gtk3u_media-3.0.so.0()(64bit) libwx_gtk3u_media-3.0.so.0(WXU_3.0)(64bit) wxGTK3-media wxGTK3-media(x86-64) wxGTK3-gl: libwx_gtk3u_gl-3.0.so.0()(64bit) libwx_gtk3u_gl-3.0.so.0(WXU_3.0)(64bit) wxGTK3-gl wxGTK3-gl(x86-64) wxBase3: libwx_baseu-3.0.so.0()(64bit) libwx_baseu-3.0.so.0(WXU_3.0)(64bit) libwx_baseu_net-3.0.so.0()(64bit) libwx_baseu_net-3.0.so.0(WXU_3.0)(64bit) libwx_baseu_xml-3.0.so.0()(64bit) libwx_baseu_xml-3.0.so.0(WXU_3.0)(64bit) wxBase3 wxBase3(x86-64) wxGTK3-devel: wxGTK3-devel wxGTK3-devel(x86-64) wxWidgets-devel wxrc(WXU_3.0)(64bit) wxGTK3-docs: wxGTK3-docs wxWidgets-docs Source checksums ---------------- http://downloads.sf.net/wxwindows/wxWidgets-3.0.0.tar.bz2 : CHECKSUM(SHA256) this package : ff340539bcb6e45d8dbce848d3c13ebce34da6ffb9004a0a88e9541bec45bf85 CHECKSUM(SHA256) upstream package : ff340539bcb6e45d8dbce848d3c13ebce34da6ffb9004a0a88e9541bec45bf85 http://downloads.sf.net/wxwindows/wxWidgets-3.0.0-docs-html.tar.bz2 : CHECKSUM(SHA256) this package : fbdd24fc712d775ae3b156eb66dcaebb7289858b4f45d3bdcfe55119a3c932f4 CHECKSUM(SHA256) upstream package : fbdd24fc712d775ae3b156eb66dcaebb7289858b4f45d3bdcfe55119a3c932f4 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/bin/fedora-review -b 1020942 Buildroot used: fedora-19-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review