[Bug 1068747] Review Request: birdie - A twitter client for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1068747



--- Comment #2 from Ryan Lerch <rlerch@xxxxxxxxxx> ---
(In reply to Mukundan Ragavan from comment #1)
> Some quick comments - 
> 
> * gcc-c++ does not need to explicitly specified in BuildRequires

Fixed.

> * source URL missing
> --- https://github.com/birdieapp/birdie/archive/1.1.tar.gz

That URL actually resolves to download birdie-1.1.tar.gz. Added a comment above
the source0 line stating that this is the URL. Is there a better way to handle
it?

> rpmlint output - 
> 
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/sv/LC_MESSAGES/birdie.mo
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/tr/LC_MESSAGES/birdie.mo
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/uk/LC_MESSAGES/birdie.mo
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/vi/LC_MESSAGES/birdie.mo
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/zh_CN/LC_MESSAGES/birdie.mo
> birdie.x86_64: W: file-not-in-%lang
> /usr/share/locale/zh_TW/LC_MESSAGES/birdie.mo
> birdie.src: W: strange-permission birdie-1.1.tar.gz 0600L
> birdie.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2)
> birdie.src: W: invalid-url Source0: birdie-1.1.tar.gz
> 2 packages and 0 specfiles checked; 0 errors, 32 warnings.
> 
> Some information from minGW on file-not-in%lang
> - http://fedoraproject.org/wiki/MinGW/Rpmlint#file-not-in-.25lang

removed the stray tab that got in there.

Also, how did you run rpmline to get the file-not-in%lang errors? I can not
reproduce those.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]