https://bugzilla.redhat.com/show_bug.cgi?id=1067664 --- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in json4s- javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: json4s-3.2.7-1.fc20.noarch.rpm json4s-javadoc-3.2.7-1.fc20.noarch.rpm json4s-3.2.7-1.fc20.src.rpm json4s.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers json4s.noarch: W: summary-ended-with-dot C Common AST for Scala JSON parsers. json4s.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers json4s.src: W: spelling-error Summary(en_US) parsers -> parser, parses, parers json4s.src: W: summary-ended-with-dot C Common AST for Scala JSON parsers. json4s.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers json4s.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 17) 3 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint json4s-javadoc json4s json4s.noarch: W: spelling-error Summary(en_US) parsers -> parser, parses, parers json4s.noarch: W: summary-ended-with-dot C Common AST for Scala JSON parsers. json4s.noarch: W: spelling-error %description -l en_US parsers -> parser, parses, parers 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Diff spec file in url and in SRPM --------------------------------- --- /home/gil/1067664-json4s/json4s.spec 2014-02-20 21:04:07.000000000 +0100 +++ /home/gil/1067664-json4s/review-json4s/srpm-unpacked/json4s.spec 2014-02-20 20:07:06.000000000 +0100 @@ -7,22 +7,22 @@ %global want_scalaz 0 -Name: json4s -Version: %{json4s_version} -Release: 1%{?dist} -Summary: Common AST for Scala JSON parsers - -License: ASL 2.0 -URL: https://github.com/json4s/json4s -Source0: https://github.com/json4s/json4s/archive/v%{json4s_version}_%{scala_version}.tar.gz +Name: json4s +Version: %{json4s_version} +Release: 1%{?dist} +Summary: Common AST for Scala JSON parsers. + +License: ASL 2.0 +URL: https://github.com/json4s/json4s +Source0: https://github.com/json4s/json4s/archive/v%{json4s_version}_%{scala_version}.tar.gz Source1: https://raw.github.com/willb/climbing-nemesis/master/climbing-nemesis.py BuildArch: noarch -BuildRequires: sbt -BuildRequires: scala +BuildRequires: sbt +BuildRequires: scala BuildRequires: python BuildRequires: maven-local BuildRequires: javapackages-tools Requires: javapackages-tools -Requires: scala +Requires: scala Requires: mvn(com.thoughtworks.paranamer:paranamer) @@ -47,5 +47,5 @@ %package javadoc -Summary: Javadoc for %{name} +Summary: Javadoc for %{name} %description javadoc @@ -135,5 +135,5 @@ # from "sbt publish" for some reason for f in $(find published -name \*.jar ) ; do - find . -ipath \*target\* -and -name $(basename $f) -exec cp '{}' $f \; + find . -ipath \*target\* -and -name $(basename $f) -exec cp '{}' $f \; done @@ -145,11 +145,11 @@ mkdir -p %{buildroot}/%{_javadocdir}/%{name} for apidir in $(find . -name api -type d) ; do - pushd $apidir - cp -rp . %{buildroot}/%{_javadocdir}/%{name} - popd + pushd $apidir + cp -rp . %{buildroot}/%{_javadocdir}/%{name} + popd done for jar in $(find published -name \*.jar | grep -v %{name}_%{scala_version}-%{version}.jar) ; do - cp $jar %{buildroot}/%{_javadir}/%{name}/$(echo $jar | cut -f5 -d/ | cut -f1 -d_).jar + cp $jar %{buildroot}/%{_javadir}/%{name}/$(echo $jar | cut -f5 -d/ | cut -f1 -d_).jar done @@ -157,14 +157,14 @@ for pom in $(find published -name \*.pom | grep -v %{name}_%{scala_version}-%{version}.pom ) ; do - shortname=$(echo $pom | cut -f5 -d/ | cut -f1 -d_) - echo installing POM $pom to %{_mavenpomdir}/JPP.%{name}-${shortname}.pom - cp $pom %{buildroot}/%{_mavenpomdir}/JPP.%{name}-${shortname}.pom - echo %{_mavenpomdir}/JPP.%{name}-${shortname}.pom >> .rpm_pomfiles - shortnames=( "${shortnames[@]}" $shortname ) + shortname=$(echo $pom | cut -f5 -d/ | cut -f1 -d_) + echo installing POM $pom to %{_mavenpomdir}/JPP.%{name}-${shortname}.pom + cp $pom %{buildroot}/%{_mavenpomdir}/JPP.%{name}-${shortname}.pom + echo %{_mavenpomdir}/JPP.%{name}-${shortname}.pom >> .rpm_pomfiles + shortnames=( "${shortnames[@]}" $shortname ) done for sub in ${shortnames[@]} ; do - echo running add_maven_depmap JPP.%{name}-${sub}.pom %{name}/${sub}.jar - %add_maven_depmap JPP.%{name}-${sub}.pom %{name}/${sub}.jar + echo running add_maven_depmap JPP.%{name}-${sub}.pom %{name}/${sub}.jar + %add_maven_depmap JPP.%{name}-${sub}.pom %{name}/${sub}.jar done Requires -------- json4s-javadoc (rpmlib, GLIBC filtered): jpackage-utils json4s (rpmlib, GLIBC filtered): javapackages-tools jpackage-utils mvn(com.fasterxml.jackson.core:jackson-annotations) mvn(com.fasterxml.jackson.core:jackson-core) mvn(com.fasterxml.jackson.core:jackson-databind) mvn(com.thoughtworks.paranamer:paranamer) mvn(joda-time:joda-time) mvn(org.joda:joda-convert) mvn(org.scala-lang:scalap) scala Provides -------- json4s-javadoc: json4s-javadoc json4s: json4s mvn(org.json4s:json4s-ast_2.10) mvn(org.json4s:json4s-core_2.10) mvn(org.json4s:json4s-ext_2.10) mvn(org.json4s:json4s-jackson_2.10) mvn(org.json4s:json4s-native_2.10) Source checksums ---------------- https://github.com/json4s/json4s/archive/v3.2.7_2.10.tar.gz : CHECKSUM(SHA256) this package : 4147985965cd1ebc4083b596fdeb168af50c326ec6fad622f68d3476d60bfe0e CHECKSUM(SHA256) upstream package : 4147985965cd1ebc4083b596fdeb168af50c326ec6fad622f68d3476d60bfe0e https://raw.github.com/willb/climbing-nemesis/master/climbing-nemesis.py : CHECKSUM(SHA256) this package : 181ac93e126e665239836b337e964ace6a4a8800e0526de0cda28e414da0c7f3 CHECKSUM(SHA256) upstream package : 181ac93e126e665239836b337e964ace6a4a8800e0526de0cda28e414da0c7f3 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -vpn json4s -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review